Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add symbol #167

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Add symbol #167

merged 3 commits into from
Mar 25, 2024

Conversation

anitacaron
Copy link
Collaborator

Fixes #144

@anitacaron anitacaron self-assigned this Mar 18, 2024
zhengj2007
zhengj2007 requested changes Mar 18, 2024
View reviewed changes
Copy link
Contributor

@zhengj2007 zhengj2007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments on the issue. I propose to use different ID and label rather than move IAO class to OMO as an annotation property.

@matentzn
Copy link
Contributor

Use OMO:0004000: #170

@anitacaron anitacaron requested a review from zhengj2007 March 25, 2024 16:54
@anitacaron anitacaron merged commit 928fb84 into master Mar 25, 2024
1 check passed
@anitacaron anitacaron deleted the anitacaron/issue144 branch June 21, 2024 08:21
@jamesaoverton jamesaoverton mentioned this pull request Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhengj2007 zhengj2007 zhengj2007 approved these changes

@matentzn matentzn Awaiting requested review from matentzn

Assignees

@anitacaron anitacaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request for adding property symbol (IAO:0000028) to OMO
3 participants
@anitacaron @matentzn @zhengj2007