Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[logging] Add crd test to logging job #158

Merged
merged 10 commits into from
Oct 29, 2024
Merged

[logging] Add crd test to logging job #158

merged 10 commits into from
Oct 29, 2024

Conversation

mgirgisf
Copy link
Contributor

@mgirgisf mgirgisf commented Oct 7, 2024

No description provided.

elfiesmelfie
elfiesmelfie requested changes Oct 8, 2024
View reviewed changes
roles/common/tasks/crd_test.yml Outdated Show resolved Hide resolved
roles/common/tasks/main.yml Outdated Show resolved Hide resolved
ci/logging_tests_controller.yml Outdated Show resolved Hide resolved
ci/vars-logging-test.yml Outdated Show resolved Hide resolved
roles/common/README.md Outdated Show resolved Hide resolved
roles/common/README.md Show resolved Hide resolved
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/068c40c5914e4bf797946710ba5f68d7

✔️ feature-verification-tests-noop SUCCESS in 5s
✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 04m 10s
✔️ functional-tests-on-osp18 SUCCESS in 1h 47m 43s
✔️ functional-logging-tests-osp18 SUCCESS in 1h 15m 20s
❌ functional-graphing-tests-osp18 RETRY_LIMIT Host unreachable in 21m 09s

@mgirgisf
Copy link
Contributor Author

recheck

@mgirgisf mgirgisf changed the title Add crd test to logging job [logging] Add crd test to logging job Oct 16, 2024
vyzigold
vyzigold requested changes Oct 17, 2024
View reviewed changes
ci/vars-logging-test.yml Outdated Show resolved Hide resolved
roles/common/tasks/crd_tests.yml Outdated Show resolved Hide resolved
roles/common/tasks/main.yml Outdated Show resolved Hide resolved
ayefimov-1
ayefimov-1 requested changes Oct 17, 2024
View reviewed changes
roles/common/tasks/crd_tests.yml Outdated Show resolved Hide resolved
ayefimov-1
ayefimov-1 approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@ayefimov-1 ayefimov-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

elfiesmelfie
elfiesmelfie reviewed Oct 22, 2024
View reviewed changes
roles/common/tasks/main.yml

- name: "Run crd tests"
when:
- common_crd_list is defined
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either the common_crd_test_id should be checked here, or made optional in crd_tests.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the other tests also.

elfiesmelfie
elfiesmelfie requested changes Oct 22, 2024
View reviewed changes
roles/common/tasks/crd_tests.yml Show resolved Hide resolved
roles/common/README.md Outdated Show resolved Hide resolved
@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/infrawatch/feature-verification-tests for 158,f043618504ed62c920792355ff94d7b404909f3e

@mgirgisf mgirgisf force-pushed the mgirgis_crd_test branch 2 times, most recently from 7903459 to 0a474d1 Compare October 23, 2024 07:54
elfiesmelfie
elfiesmelfie requested changes Oct 23, 2024
View reviewed changes
roles/common/tasks/pod_tests.yml Outdated
@@ -1,7 +1,7 @@
---
- block:
# expects that one line will be returned
# todo: define what hapens when there are multiple pods returned
# tod: define what hapens when there are multiple pods returned
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# tod: define what hapens when there are multiple pods returned
# todo: define what happens when there are multiple pods returned

roles/common/README.md
@@ -90,6 +98,14 @@ can be set at the play level.
common_project_list:
- openshift-openstack-infra
- openshift
- name: "Verify crd"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: "Verify crd"
- name: "Verify crd"

@softwarefactory-project-zuul softwarefactory-project-zuul
Copy link

Merge Failed.

This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.
Warning:
Error merging github.com/infrawatch/feature-verification-tests for 158,6ee9616e2c7403b9da6acd08b40ed5ff2fb6bcc2

@elfiesmelfie elfiesmelfie merged commit 65b8296 into master Oct 29, 2024
8 checks passed
@elfiesmelfie elfiesmelfie deleted the mgirgis_crd_test branch October 29, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayefimov-1 ayefimov-1 ayefimov-1 approved these changes

@elfiesmelfie elfiesmelfie elfiesmelfie approved these changes

@myadla myadla Awaiting requested review from myadla

@vyzigold vyzigold Awaiting requested review from vyzigold

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mgirgisf @elfiesmelfie @vyzigold @ayefimov-1