Adding observability Strategy tests and fixing typo in Prometheus URL variable in test_alerts #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing prom_host Addin prom_url
Fixing typo in prometheus URL varibale in test_alerts
lnatapov
changed the title
lnatapov
changed the title
csibbitt
reviewed
Feb 23, 2023
| changed_when: false | ||
|
|
||
|
|
||
| - name: "Verify that Prometheus object didn't respawn" |
There was a problem hiding this comment.
Suggested change
| - name: "Verify that Prometheus object didn't respawn" | |
| - name: "Verify that Prometheus pod didn't respawn" |
| changed_when: false | ||
|
|
||
|
|
||
| - name: "Verify that Alertmanager object didn't respawn" |
There was a problem hiding this comment.
Suggested change
| - name: "Verify that Alertmanager object didn't respawn" | |
| - name: "Verify that Alertmanager pod didn't respawn" |
| changed_when: false | ||
|
|
||
|
|
||
| - name: "Verify that elasticsearch object didn't respawn" |
There was a problem hiding this comment.
Suggested change
| - name: "Verify that elasticsearch object didn't respawn" | |
| - name: "Verify that elasticsearch pod didn't respawn" |
csibbitt
reviewed
Feb 23, 2023
|
|
||
|
|
||
| - name: "Wait 2 minutes before checking that pods didn't return" | ||
| ansible.builtin.shell: |
There was a problem hiding this comment.
There is an ansible module for this if you prefer https://docs.ansible.com/ansible/latest/collections/ansible/builtin/pause_module.html
csibbitt
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.