Update GH actions to use ubuntu-latest #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Ubuntu 20.04 runner image will be fully unsupported by April 1, 2025. Actions need to be updated to a newer version. For some jobs we are already using ubuntu-latest, so use the same for the jobs using ubuntu20.04
vkmc
force-pushed
the
gh-actions-to-ubuntu-latest
branch
from
bb0185f to
a2a1ece
Compare
Issues found with thew new linter should be fixed in a follow up PR
vkmc
force-pushed
the
gh-actions-to-ubuntu-latest
branch
from
c78d4d2 to
05015c4
Compare
vkmc
force-pushed
the
gh-actions-to-ubuntu-latest
branch
from
05015c4 to
98c2f8f
Compare
elfiesmelfie
approved these changes
Feb 13, 2025
| @@ -0,0 +1,83 @@ | |||
| # This file contains ignores rule violations for ansible-lint | |||
There was a problem hiding this comment.
I think you can update the ansible-lint config to skip linting the roles/servicetelemetry/ directoty
Same for the build/run-stf-ci/ directory., although I think that the effort to update those is safer.
There was a problem hiding this comment.
Indeed, we can work on fixing the linting issues or configuring ansible-lint in a follow up patch.
Comment on lines
+13
to
+18
| - name: Set up Python | ||
| # This is the version of the action for setting up Python, not the Python version. | ||
| uses: actions/setup-python@v5 | ||
| with: | ||
| # Set exact version of a Python version or can use '3.x'. | ||
| python-version: '3.12.8' |
| @@ -65,7 +80,7 @@ jobs: | |||
|
|
|||
| build-operator-check: | |||
| name: Build Operator check | |||
| runs-on: ubuntu-20.04 | |||
| runs-on: ubuntu-latest | |||
There was a problem hiding this comment.
Thanks for updating this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ubuntu 20.04 runner image will be fully unsupported by April 1, 2025.
Actions need to be updated to a newer version.
For some jobs we are already using ubuntu-latest, so use the same for the jobs using ubuntu20.04