fix(overlays): fix OverlayController being added to a target that is already removed #2687
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: Verify changes | |
| on: pull_request | |
| jobs: | |
| verify: | |
| name: Verify changes | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v2 | |
| - name: Setup Node 14.x | |
| uses: actions/setup-node@v1 | |
| with: | |
| node-version: 14.x | |
| - name: Get yarn cache directory | |
| id: yarn-cache-dir | |
| run: | | |
| echo "::set-output name=dir::$(yarn cache dir)" | |
| - uses: actions/cache@v2 | |
| id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`) | |
| with: | |
| path: ${{ steps.yarn-cache-dir.outputs.dir }} | |
| key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} | |
| restore-keys: | | |
| ${{ runner.os }}-yarn- | |
| - name: Install Dependencies | |
| run: yarn --frozen-lockfile | |
| - name: Lint | |
| run: npm run lint | |
| - name: Bundlesize | |
| run: npm run bundlesize | |
| browser-tests: | |
| name: Browser tests | |
| runs-on: ubuntu-latest | |
| steps: | |
| - uses: actions/checkout@v2 | |
| - name: Setup Node 14.x | |
| uses: actions/setup-node@v1 | |
| with: | |
| node-version: 14.x | |
| - name: Get yarn cache directory | |
| id: yarn-cache-dir | |
| run: | | |
| echo "::set-output name=dir::$(yarn cache dir)" | |
| - uses: actions/cache@v2 | |
| id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`) | |
| with: | |
| path: ${{ steps.yarn-cache-dir.outputs.dir }} | |
| key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} | |
| restore-keys: | | |
| ${{ runner.os }}-yarn- | |
| - name: Install Dependencies | |
| run: yarn --frozen-lockfile | |
| - uses: microsoft/playwright-github-action@v1 | |
| - name: Test | |
| run: npm run test:browser | |
| node-tests: | |
| name: Node tests | |
| runs-on: ${{ matrix.os }} | |
| strategy: | |
| matrix: | |
| node-version: [14.x] | |
| os: [ubuntu-latest, windows-latest] | |
| steps: | |
| - uses: actions/checkout@v2 | |
| - name: Setup Node ${{ matrix.node-version }} | |
| uses: actions/setup-node@v1 | |
| with: | |
| node-version: ${{ matrix.node-version }} | |
| - name: Get yarn cache directory | |
| id: yarn-cache-dir | |
| run: | | |
| echo "::set-output name=dir::$(yarn cache dir)" | |
| - uses: actions/cache@v2 | |
| id: yarn-cache # use this to check for `cache-hit` (`steps.yarn-cache.outputs.cache-hit != 'true'`) | |
| with: | |
| path: ${{ steps.yarn-cache-dir.outputs.dir }} | |
| key: ${{ runner.os }}-yarn-${{ hashFiles('**/yarn.lock') }} | |
| restore-keys: | | |
| ${{ runner.os }}-yarn- | |
| - name: Install Dependencies | |
| run: yarn --frozen-lockfile | |
| - name: Test | |
| run: npm run test:node |