fix(overlays): fix OverlayController being added to a target that is …

…already removed
ing-bank · Nov 2, 2023 · 6031205 · 6031205
1 parent 6296e51
commit 6031205
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/.changeset/nice-months-applaud.md b/.changeset/nice-months-applaud.md
@@ -0,0 +1,5 @@
+---
+'@lion/overlays': patch
+---
+
+fix(overlays): fix OverlayController being added to a target that is already removed
diff --git a/packages/overlays/src/OverlayMixin.js b/packages/overlays/src/OverlayMixin.js
@@ -166,17 +166,17 @@ export const OverlayMixinImplementation = superclass =>
       // we do a setup after every connectedCallback as firstUpdated will only be called once
       this.__needsSetup = true;
       this.updateComplete.then(() => {
-        if (this.__needsSetup) {
+        // The overlay can already be removed during the update, so let's make sure it is still connected
+        if (this.__needsSetup && this.isConnected) {
           this._setupOverlayCtrl();
         }
         this.__needsSetup = false;
       });
     }
 
     disconnectedCallback() {
-      if (super.disconnectedCallback) {
-        super.disconnectedCallback();
-      }
+      super.disconnectedCallback();
+
       if (this._overlayCtrl) {
         this._teardownOverlayCtrl();
       }