Skip to content

Commit

Permalink
Merge pull request #1977 from ing-bank/feat/providenceNext
Browse files Browse the repository at this point in the history
providence improvements, alignment with latest browsers and deps, more
  • Loading branch information
tlouisse authored Nov 9, 2023
2 parents c1d66f1 + bdb038e commit 86d3db8
Show file tree
Hide file tree
Showing 172 changed files with 15,739 additions and 17,893 deletions.
17 changes: 17 additions & 0 deletions .changeset/six-geckos-relate.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
---
'providence-analytics': minor
---

Many improvements:

- rewritten from babel to swc
- swc traversal tool with babel
- increased performance
- better windows compatibility

BREAKING:

- package fully written as esm
- entrypoints changed:
- `@providence-analytics/src/cli` => `@providence-analytics/cli.js`
- `@providence-analytics/analyzers` => `@providence-analytics/analyzers.js`
2 changes: 1 addition & 1 deletion .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ module.exports = {
files: [
'**/test-suites/**/*.js',
'**/test/**/*.js',
'**/test-node/**/*.js',
'**/test-node/**/*.{j,mj}s',
'**/demo/**/*.js',
'**/docs/**/*.js',
'**/*.config.js',
Expand Down
4 changes: 4 additions & 0 deletions docs/components/collapsible/assets/CustomCollapsible.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ export class CustomCollapsible extends LionCollapsible {
contentNode.style.setProperty('opacity', '1');
contentNode.style.setProperty('padding', '12px 0');
contentNode.style.setProperty('max-height', '0px');
// @ts-ignore
// eslint-disable-next-line no-promise-executor-return
await new Promise(resolve => requestAnimationFrame(() => resolve()));
contentNode.style.setProperty('max-height', expectedHeight);
await this._waitForTransition({ contentNode });
Expand Down Expand Up @@ -105,6 +107,8 @@ export class CustomCollapsible extends LionCollapsible {
*/
async __calculateHeight(contentNode) {
contentNode.style.setProperty('max-height', '');
// @ts-ignore
// eslint-disable-next-line no-promise-executor-return
await new Promise(resolve => requestAnimationFrame(() => resolve()));
return this._contentHeight; // Expected height i.e. actual size once collapsed after animation
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { OverlaysManager } from 'overlays';
import { OverlaysManager, OverlaysManager as OverlaysManager2 } from 'overlays';
import { singletonManager } from 'singleton-manager';
import { OverlaysManager as OverlaysManager2 } from './node_modules/page-b/node_modules/overlays/index.js';

let compatibleManager1;
let compatibleManager2;
Expand Down
Loading

0 comments on commit 86d3db8

Please sign in to comment.