Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] okr: Migration to 17.0 #166

Open
wants to merge 3 commits into
base: 17.0
Choose a base branch
from

Conversation

mav-adhoc
Copy link
Contributor

No description provided.

@roboadhoc
Copy link

@mav-adhoc mav-adhoc changed the title [ADD] okr: okr by mav [MIG] okr: migration to v17 Feb 1, 2024
@mav-adhoc mav-adhoc changed the title [MIG] okr: migration to v17 [MIG] okr: Migration to 17.0 Feb 1, 2024
@mav-adhoc mav-adhoc force-pushed the 17.0-t-34208-mav branch 11 times, most recently from e53a821 to 6b2afc6 Compare February 6, 2024 16:36
Copy link
Contributor

@jok-adhoc jok-adhoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mosca, lo veo excelente en lo que es codigo. Lo unico el comentario que dejé, no teminaria de entender el juego entre ambos modelos, o si falta un parte de results del general.

objective = fields.Many2one('okr.objective', required=True)
priority = fields.Selection([
('very_high', 'Muy Alta'),
('high', 'ALta'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: Alta

name = fields.Char(required=True)
description = fields.Char()
responsible = fields.Many2one('res.users', required=True)
objective = fields.Many2one('okr.objective', required=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no estaria entendiendo la logica de las relaciones entre ambos modelos. Sobretodo con el calculo de resultado. Entiendo que uno deberia responder a la sumatoria proporcional del otro

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants