Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP]l10n_ar_account_tax_settlement: retenciones y percepciones IVA txt #153

Closed
wants to merge 1 commit into from
Closed

[IMP]l10n_ar_account_tax_settlement: retenciones y percepciones IVA txt #153

wants to merge 1 commit into from

Conversation

pablohmontenegro
Copy link
Contributor

Ticket: 54274

@roboadhoc
Copy link
Contributor

Pull request status dashboard.

@pablohmontenegro pablohmontenegro force-pushed the 13.0-h-54274-pam branch 3 times, most recently from 06dd167 to 3e7af3c Compare November 29, 2022 13:02
ica-adhoc
ica-adhoc suggested changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@ica-adhoc ica-adhoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pablohmontenegro check the comments and prove that functions with the changes requested

l10n_ar_account_tax_settlement/models/account_journal.py Outdated
content += codigo_regimen[:3]

# cuit agente (long 11)
line.move_id.partner_id.ensure_vat()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ensure_vat() return l10n_ar_vat if this exists, call directly on add to content

l10n_ar_account_tax_settlement/models/account_journal.py Outdated
content += codigo_regimen[:3]

# cuit agente (long 11)
payment.partner_id.ensure_vat()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ensure_vat() return l10n_ar_vat if this exists, call directly on add to content

l10n_ar_account_tax_settlement/models/account_journal.py Show resolved Hide resolved
l10n_ar_account_tax_settlement/models/account_journal.py Show resolved Hide resolved
@ica-adhoc
Copy link
Contributor

@roboadhoc r+

roboadhoc pushed a commit that referenced this pull request Dec 16, 2022
@pablohmontenegro
[IMP]l10n_ar_account_tax_settlement: retenciones y percepciones IVA txt
c06fc8b 
closes #153

Ticket: 54274
Signed-off-by: Nacho Cainelli <[email protected]>
@roboadhoc roboadhoc temporarily deployed to merge December 16, 2022 19:44 Inactive
@roboadhoc roboadhoc closed this Dec 16, 2022
@fw-bot-adhoc fw-bot-adhoc mentioned this pull request Dec 16, 2022
Open
@fw-bot-adhoc
Copy link
Contributor

@pablohmontenegro @ica-adhoc this pull request has forward-port PRs awaiting action (not merged or closed):
#163

7 similar comments
@fw-bot-adhoc
Copy link
Contributor

@pablohmontenegro @ica-adhoc this pull request has forward-port PRs awaiting action (not merged or closed):
#163

@fw-bot-adhoc
Copy link
Contributor

@pablohmontenegro @ica-adhoc this pull request has forward-port PRs awaiting action (not merged or closed):
#163

@fw-bot-adhoc
Copy link
Contributor

@pablohmontenegro @ica-adhoc this pull request has forward-port PRs awaiting action (not merged or closed):
#163

@fw-bot-adhoc
Copy link
Contributor

@pablohmontenegro @ica-adhoc this pull request has forward-port PRs awaiting action (not merged or closed):
#163

@fw-bot-adhoc
Copy link
Contributor

@pablohmontenegro @ica-adhoc this pull request has forward-port PRs awaiting action (not merged or closed):
#163

@fw-bot-adhoc
Copy link
Contributor

@pablohmontenegro @ica-adhoc this pull request has forward-port PRs awaiting action (not merged or closed):
#163

@fw-bot-adhoc
Copy link
Contributor

@pablohmontenegro @ica-adhoc this pull request has forward-port PRs awaiting action (not merged or closed):
#163

@fw-bot-adhoc fw-bot-adhoc deleted the 13.0-h-54274-pam branch December 30, 2022 20:36
@fw-bot-adhoc
Copy link
Contributor

@pablohmontenegro @ica-adhoc this pull request has forward-port PRs awaiting action (not merged or closed):
#163

1 similar comment
@fw-bot-adhoc
Copy link
Contributor

@pablohmontenegro @ica-adhoc this pull request has forward-port PRs awaiting action (not merged or closed):
#163

pablohmontenegro added a commit to adhoc-dev/odoo-argentina-ee that referenced this pull request May 22, 2023
@pablohmontenegro
[FW][IMP]l10n_ar_account_tax_settlement: retenciones y percepciones I…
0452e96 
…VA txt ingadhoc#163

Cerré este FP:
ingadhoc#163

El pr que viene de 13 es este:
ingadhoc#153
pablohmontenegro added a commit to adhoc-dev/odoo-argentina-ee that referenced this pull request May 22, 2023
@pablohmontenegro
[FW][IMP]l10n_ar_account_tax_settlement: retenciones y percepciones I…
3c9ab4c 
…VA txt ingadhoc#163

Cerré este FP:
ingadhoc#163

El pr que viene de 13 es este:
ingadhoc#153
@pablohmontenegro pablohmontenegro mentioned this pull request May 22, 2023
Closed
pablohmontenegro added a commit to adhoc-dev/odoo-argentina-ee that referenced this pull request Jul 28, 2023
@pablohmontenegro
[FW][IMP]l10n_ar_account_tax_settlement: retenciones y percepciones I…
e973f54 
…VA txt ingadhoc#163

Cerré este FP:
ingadhoc#163

El pr que viene de 13 es este:
ingadhoc#153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ica-adhoc ica-adhoc ica-adhoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pablohmontenegro @roboadhoc @ica-adhoc @fw-bot-adhoc