Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including tax amount in the computation of 'none_invoiced_amount' #4

Open
wants to merge 1 commit into
base: 8.0
Choose a base branch
from

Conversation

valentinagiuliani1991
Copy link

In the computation of field 'none_invoice_amount' we included tax amount of order_line:
without this control you could create purchase orders with amounts exceeding credit limits set.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 49.615% when pulling a9fb1ca on odoo-isa:8.0 into 931a16c on ingadhoc:8.0.

@jjscarafia
Copy link
Member

Thanks for the PR. Sorry for the late response.
You are right with the issue but I think we should use tax.compute method because tax not always is a percentage and you can have more than one taxes.
There are many examples in odoo code on how to do this.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants