Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] l10n_uy_edi: Fix en el manejo de formatos de reporte #245

Closed
wants to merge 1 commit into from
Closed

[FIX] l10n_uy_edi: Fix en el manejo de formatos de reporte #245

wants to merge 1 commit into from

Conversation

mem-adhoc
Copy link
Contributor

Ticket: 80829

@mem-adhoc mem-adhoc mentioned this pull request Oct 14, 2024
Closed
@roboadhoc
Copy link
Contributor

Pull request status dashboard.

@mem-adhoc mem-adhoc force-pushed the 16.0-h-80829-mem branch 3 times, most recently from 788a16d to 0a3c495 Compare October 14, 2024 16:54
pablohmontenegro
pablohmontenegro suggested changes Oct 14, 2024
View reviewed changes
l10n_uy_edi/models/l10n_uy_cfe.py Outdated Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
l10n_uy_edi/models/res_company.py
@@ -156,6 +156,10 @@ def _l10n_uy_ucfe_query(self, method, req_data={}, return_transport=False):
res = company._uy_get_client(company.l10n_uy_ucfe_query_url, return_transport=return_transport)
client = res[0] if isinstance(res, tuple) else res
transport = res[1] if isinstance(res, tuple) else False
if req_data.get('nombreParametros') and req_data.get('valoresParametros'):
ArrayOfstring = client.get_type('{http://schemas.microsoft.com/2003/10/Serialization/Arrays}ArrayOfstring')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mem-adhoc necesitamos un enlace acá? que pasa si no está disponible o cambia?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pablohmontenegro Pablito esto no es un enlace, basicamente consultamos a la api el formato que necesitamos para informar los campos! no va a cambiar

@pablohmontenegro
Copy link
Contributor

pablohmontenegro commented Oct 14, 2024 •
edited
Loading

Buenas @mem-adhoc falla runbot, ¿quizás habría que hacer un rebase? ¿consultar en canal "devs" de slack?

zaoral
zaoral suggested changes Oct 14, 2024
View reviewed changes
l10n_uy_edi/tests/test_report_params.py Show resolved Hide resolved
l10n_uy_edi/tests/test_report_params.py Outdated Show resolved Hide resolved
l10n_uy_edi/tests/test_report_params.py Outdated Show resolved Hide resolved
l10n_uy_edi/tests/test_report_params.py Outdated Show resolved Hide resolved
l10n_uy_edi/tests/test_report_params.py Outdated Show resolved Hide resolved
@zaoral
Copy link
Contributor

zaoral commented Oct 14, 2024

@roboadhoc r+

roboadhoc pushed a commit that referenced this pull request Oct 14, 2024
@mem-adhoc
[FIX] l10n_uy_edi: Fix en el manejo de formatos de reporte
61e642e 
closes #245

Ticket: 80829
Signed-off-by: Katherine Zaoral <[email protected]>
@roboadhoc roboadhoc closed this Oct 14, 2024
@fw-bot-adhoc fw-bot-adhoc mentioned this pull request Oct 14, 2024
Open
@mem-adhoc mem-adhoc mentioned this pull request Oct 15, 2024
Closed
@zaoral zaoral deleted the 16.0-h-80829-mem branch October 17, 2024 11:20
@fw-bot-adhoc
Copy link
Contributor

@mem-adhoc @zaoral this pull request has forward-port PRs awaiting action (not merged or closed):

10 similar comments
@fw-bot-adhoc
Copy link
Contributor

@mem-adhoc @zaoral this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot-adhoc
Copy link
Contributor

@mem-adhoc @zaoral this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot-adhoc
Copy link
Contributor

@mem-adhoc @zaoral this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot-adhoc
Copy link
Contributor

@mem-adhoc @zaoral this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot-adhoc
Copy link
Contributor

@mem-adhoc @zaoral this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot-adhoc
Copy link
Contributor

@mem-adhoc @zaoral this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot-adhoc
Copy link
Contributor

@mem-adhoc @zaoral this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot-adhoc
Copy link
Contributor

@mem-adhoc @zaoral this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot-adhoc
Copy link
Contributor

@mem-adhoc @zaoral this pull request has forward-port PRs awaiting action (not merged or closed):

@fw-bot-adhoc
Copy link
Contributor

@mem-adhoc @zaoral this pull request has forward-port PRs awaiting action (not merged or closed):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablohmontenegro pablohmontenegro pablohmontenegro requested changes

@zaoral zaoral zaoral approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mem-adhoc @roboadhoc @pablohmontenegro @zaoral @fw-bot-adhoc