improve performance for consistency

ingef · Dec 11, 2024 · 21cfd8e · 21cfd8e
1 parent 6a8e16b
commit 21cfd8e
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/backend/src/main/java/com/bakdata/conquery/io/storage/NamespacedStorage.java b/backend/src/main/java/com/bakdata/conquery/io/storage/NamespacedStorage.java
@@ -8,6 +8,7 @@
 import com.bakdata.conquery.models.datasets.Table;
 import com.bakdata.conquery.models.datasets.concepts.Concept;
 import com.bakdata.conquery.models.identifiable.NamespacedStorageProvider;
+import com.bakdata.conquery.models.identifiable.ids.Id;
 import com.bakdata.conquery.models.identifiable.ids.specific.ConceptId;
 import com.bakdata.conquery.models.identifiable.ids.specific.DatasetId;
 import com.bakdata.conquery.models.identifiable.ids.specific.ImportId;
@@ -22,6 +23,8 @@ public interface NamespacedStorage extends ConqueryStorage, NamespacedStoragePro
 
 	Stream<Import> getAllImports();
 
+	Stream<ImportId> getAllImportIds();
+
 	void updateImport(Import imp);
 
 	void removeImport(ImportId id);

diff --git a/backend/src/main/java/com/bakdata/conquery/io/storage/NamespacedStorageImpl.java b/backend/src/main/java/com/bakdata/conquery/io/storage/NamespacedStorageImpl.java
@@ -103,6 +103,11 @@ private Import getImportFromStorage(ImportId id) {
 		return imports.get(id);
 	}
 
+	@Override
+	public Stream<ImportId> getAllImportIds() {
+		return imports.getAllKeys().map(ImportId.class::cast);
+	}
+
 	@Override
 	public Stream<Import> getAllImports() {
 		return imports.getAll();

diff --git a/...ain/java/com/bakdata/conquery/models/messages/namespaces/specific/RequestConsistency.java b/...ain/java/com/bakdata/conquery/models/messages/namespaces/specific/RequestConsistency.java
@@ -23,13 +23,15 @@ public class RequestConsistency extends WorkerMessage {
 
     @Override
     public void react(Worker context) throws Exception {
+		log.info("BEGIN Gather consistency information");
         // Gather ImportIds
-        Set<ImportId> workerImports = context.getStorage().getAllImports().map(Import::getId).collect(Collectors.toSet());
+        Set<ImportId> workerImports = context.getStorage().getAllImportIds().collect(Collectors.toSet());
 
         // Gather BucketIds
-        Set<BucketId> workerBuckets = context.getStorage().getAllBuckets().map(Bucket::getId).collect(Collectors.toSet());
+        Set<BucketId> workerBuckets = context.getStorage().getAllBucketIds().collect(Collectors.toSet());
 
         // Send report
         context.send(new ReportConsistency(context.getInfo().getId(), workerImports, workerBuckets));
+		log.debug("FINISHED Gather consistency information");
     }
 }