Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: datepicker blocks input field #3164

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Conversation

MarcoKorinth
Copy link
Contributor

Changes

  • fixed bug: datepicker opens over input field
  • datepicker only opens after clicking the new calendar icon inside the input field
  • datepicker starts in year selection mode by default

@MarcoKorinth MarcoKorinth requested a review from Kadrian August 31, 2023 12:56
@MarcoKorinth MarcoKorinth force-pushed the feat/datepicker-changes branch from 553bd28 to 4277d5a Compare August 31, 2023 13:11
Copy link
Collaborator

@Kadrian Kadrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be happy if you tried reusing IconButton, otherwise looks pretty good!

frontend/src/js/ui-components/InputDate/InputDate.tsx Outdated Show resolved Hide resolved
frontend/src/js/common/helpers/mergeRefs.ts Outdated Show resolved Hide resolved
frontend/src/js/ui-components/InputDate/InputDate.tsx Outdated Show resolved Hide resolved
@MarcoKorinth MarcoKorinth force-pushed the feat/datepicker-changes branch from 4277d5a to a292562 Compare September 5, 2023 06:02
@MarcoKorinth MarcoKorinth force-pushed the feat/datepicker-changes branch from a292562 to 383f61b Compare September 5, 2023 06:05
@MarcoKorinth MarcoKorinth requested a review from Kadrian September 5, 2023 06:12
Copy link
Collaborator

@Kadrian Kadrian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
Slightly funny that the year picker half way overlays the day picker if there aren't that many years. But I hope that will just be fixed in the backend with more available years, cc @awildturtok

Here's a small suggestion #3166

@MarcoKorinth MarcoKorinth force-pushed the feat/datepicker-changes branch from 2a5b3e0 to 383f61b Compare September 6, 2023 09:09
@MarcoKorinth MarcoKorinth merged commit c307147 into develop Sep 6, 2023
6 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feat/datepicker-changes branch September 6, 2023 09:24
@awildturtok
Copy link
Collaborator

@MarcoKorinth kannst du bitte die dependencies auf eva seite gleichstellen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants