adds cypress tests for index service #3227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Thonagel <[email protected]>
Signed-off-by: Max Thonagel <[email protected]>
|
@SebChmie das ist ein alter PR den ich jetzt endlich fixen konnte. Erfügt einen Cypress Test für den Index Service hinzu |
SebChmie
approved these changes
May 27, 2024
| @@ -126,7 +139,7 @@ context("Admin UI Single Dataset", () => { | |||
| it("Counts are right", () => { | |||
| visitAdminUI(`datasets/${testDSID}/connectors/${testDSID}.concept1.column`); | |||
| cy.get('[data-test-id="accordion-Filters"] > .card-header').contains("20 entries"); | |||
| cy.get('[data-test-id="accordion-Selects"] > .card-header').contains("16 entries"); | |||
| cy.get('[data-test-id="accordion-Selects"] > .card-header').contains("17 entries"); | |||
There was a problem hiding this comment.
Muss die Anzahl von Entries hardgecoded sein?
There was a problem hiding this comment.
Für einen Test ist das gut so.
Da man Testdaten nicht aus dem zu testenden Code erzeugen soll, braucht man entweder eine Referenzimplementierung gegen die man testet oder einen festen Datensatz, aus den man liest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.