Feature/integrate object initialization upon parsing #3499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thoniTUB
changed the base branch from
develop
to
feature/more-http-import-for-tests
awildturtok
requested changes
Jul 25, 2024
backend/src/main/java/com/bakdata/conquery/io/jackson/Initializing.java
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| if (dataset == null) { | ||
| // TODO remove this as the dataset can be derived from the storage and does not need to be explicitly declared |
There was a problem hiding this comment.
wird jetzt über den Storage aufgelöst
| int2ext = mapIndex.getIndex(new MapIndexKey(resolvedURI, internalColumn, externalTemplate)); | ||
| MapIndexKey key = new MapIndexKey(resolvedURI, internalColumn, externalTemplate); | ||
| try { | ||
| int2ext = mapIndex.getIndex(key); |
There was a problem hiding this comment.
das heißt die werden jetzt schon beim reinladen initialisiert? Das halte ich für keine gute Idee
There was a problem hiding this comment.
Dadurch wird der Upload endlos verlangsamt
There was a problem hiding this comment.
Ich kann das nach hinten verlagern, aber das parsen der Mappings ist normalerweise sehr fix.
There was a problem hiding this comment.
nicht wenn man es seriell macht was ja dadurch implizit passiert
There was a problem hiding this comment.
Ich probiere es mal mit einem wrap in ComputableFuture
…ture/integrate-object-initialization-upon-parsing # Conflicts: # backend/src/main/java/com/bakdata/conquery/mode/NamespaceHandler.java # backend/src/main/java/com/bakdata/conquery/models/worker/DatasetRegistry.java # backend/src/main/java/com/bakdata/conquery/models/worker/Namespace.java # backend/src/main/java/com/bakdata/conquery/resources/admin/rest/AdminDatasetProcessor.java # backend/src/test/java/com/bakdata/conquery/integration/json/ConqueryTestSpec.java # backend/src/test/java/com/bakdata/conquery/models/datasets/concepts/tree/GroovyIndexedTest.java
thoniTUB
changed the base branch from
feature/more-http-import-for-tests
to
develop
…alization-upon-parsing
…alization-upon-parsing # Conflicts: # backend/src/test/java/com/bakdata/conquery/integration/json/ConqueryTestSpec.java
awildturtok
requested changes
Jul 29, 2024
backend/src/main/java/com/bakdata/conquery/models/config/XodusStoreFactory.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/models/index/IndexService.java
Outdated
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/models/index/MapInternToExternMapper.java
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/models/index/MapInternToExternMapper.java
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/models/index/MapInternToExternMapper.java
Show resolved
Hide resolved
backend/src/main/java/com/bakdata/conquery/models/index/MapInternToExternMapper.java
Show resolved
Hide resolved
…ation more visible to the developer
awildturtok
approved these changes
Aug 6, 2024
backend/src/main/java/com/bakdata/conquery/models/index/IndexCreationException.java
Outdated
Show resolved
Hide resolved
…reationException.java corrects failure message Co-authored-by: awildturtok <[email protected]>
…alization-upon-parsing # Conflicts: # backend/src/main/java/com/bakdata/conquery/models/datasets/concepts/tree/TreeConcept.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next step towards caching.
Objects that are deserialized by jackson can be initialized automatically by jackson. This allows transparent and uniform initialization for deserialized object independent of if they stem from the api or storage