Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix render error on admin ui imports #3602

Merged
merged 7 commits into from
Oct 16, 2024
Merged

Conversation

thoniTUB
Copy link
Collaborator

@thoniTUB thoniTUB commented Oct 14, 2024

  • adds minimal test data for e2e so that we have an import to import
  • adds test data attributes data-cy to table rows for cypress
  • adds smoke test for datasets, dataset, table and import/tag

@thoniTUB thoniTUB marked this pull request as ready for review October 14, 2024 10:11
Comment on lines +8 to +17
<#assign table=c.imp.table.resolve() />
<#assign dataset=c.imp.dataset.resolve() />
<@breadcrumbs.breadcrumbs
labels=["Datasets", c.imp.table.dataset.label, "Tables", c.imp.table.label, "Tags", c.imp.id]
labels=["Datasets", dataset.label, "Tables", table.label, "Tags", c.imp.id]
links=[
"/admin-ui/datasets",
"/admin-ui/datasets/${c.imp.table.dataset.id}",
"/admin-ui/datasets/${c.imp.table.dataset.id}#Tables",
"/admin-ui/datasets/${c.imp.table.dataset.id}/tables/${c.imp.table.id}",
"/admin-ui/datasets/${c.imp.table.dataset.id}/tables/${c.imp.table.id}#Tags"
"/admin-ui/datasets/${c.imp.table.dataset}",
"/admin-ui/datasets/${c.imp.table.dataset}#Tables",
"/admin-ui/datasets/${c.imp.table.dataset}/tables/${c.imp.table}",
"/admin-ui/datasets/${c.imp.table.dataset}/tables/${c.imp.table}#Tags"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@awildturtok das ist der eigentliche Fix

@thoniTUB thoniTUB enabled auto-merge October 15, 2024 09:56
@thoniTUB thoniTUB merged commit 7b9bd0f into develop Oct 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants