Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use caffeine in CachedStore and adapt ManagedInternalForm for state p… #3607

Open
wants to merge 33 commits into
base: develop
Choose a base branch
from

Conversation

thoniTUB
Copy link
Collaborator

…ersistence

@thoniTUB thoniTUB requested a review from awildturtok October 21, 2024 17:51
public CachedStore(Store<KEY, VALUE> store, CaffeineSpec caffeineSpec) {
this.store = store;
cache = Caffeine.from(caffeineSpec)
// .recordStats(() -> new MetricsStatsCounter(metricRegistry, "cache."+store.toString()))
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics hinzufügen

@@ -258,6 +254,9 @@ public synchronized void finish(ExecutionState executionState) {

getExecutionManager().updateState(getId(), executionState);

// Persist state of this execution
metaStorage.updateExecution(this);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wird finish nicht immer vom execution Manager aufgerufen, so dass der das schon machen sollte?

}/**
* Cache for execution states.
*/
private final Cache<ManagedExecutionId, State> executionStates =
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hier auch eine ☕🥓?

@@ -144,6 +145,7 @@ private static Map<String, AbsoluteFormQuery> createTimeStratifiedQueries(Range<

@Nullable
@Override
@JsonIgnore
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D

@thoniTUB thoniTUB marked this pull request as ready for review November 8, 2024 07:37
@thoniTUB
Copy link
Collaborator Author

thoniTUB commented Nov 8, 2024

@awildturtok Kannst du bitte nochmal drüber schauen, das Laden der Stores ist jetzt konfigurierbar, wo bei der Bucket und CBlock dennoch bei jedem Start direkt geladen werden durch den BucketManager

Und ich habe den LoadStorageTask abgeändert, so dass er im ManagerNode, ShardNode und Standalone genutzt werden kann.

# Conflicts:
#	backend/src/main/java/com/bakdata/conquery/commands/ManagerNode.java
#	backend/src/main/java/com/bakdata/conquery/models/forms/managed/ExternalExecution.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants