Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show connector/table when referencing a filter #3626

Merged
merged 4 commits into from
Nov 29, 2024

Conversation

thoniTUB
Copy link
Collaborator

grafik

@thoniTUB thoniTUB requested a review from awildturtok November 28, 2024 16:04
@thoniTUB
Copy link
Collaborator Author

@awildturtok e2e test liefer ich noch nach

@awildturtok
Copy link
Collaborator

Code Scanning knallt

Copy link
Collaborator

@awildturtok awildturtok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@@ -10,7 +10,7 @@ import { Icon } from "../icon/FaIcon";

const Container = styled("div")`
display: grid;
grid-template-columns: 110px 30px auto 1fr;
grid-template-columns: 110px 30px auto auto auto auto 1fr;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚗🚗🚗🚗 🇫🇷

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D

Comment on lines +79 to +81
<Text>&gt;</Text>
<Text>{connectorLabel}</Text>
<Text>&gt;</Text>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<Text>&gt;</Text>
<Text>{connectorLabel}</Text>
<Text>&gt;</Text>
<Text>&gt;&nbsp;{connectorLabel}&nbsp;&gt;</Text>

warum nicht so?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guter punkt

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grafik
Das macht leider das Spacing ungleichmäßig

@thoniTUB thoniTUB enabled auto-merge November 29, 2024 11:44
@thoniTUB thoniTUB merged commit 7a125d4 into develop Nov 29, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants