Skip to content

Conversation

abeforgit
Copy link
Contributor

@abeforgit abeforgit commented Aug 18, 2024

While testing git-subrepo, I found some gotchas with regards to nested subrepos. With a bit of thinking, the way git-subrepo acts is logical, but maybe not immediately intuitive.

This PR adds a section on working with nested subrepos to the readme. I hope it explains the logic in a clear manner.

Please let me know if I made some mistakes, I've only really just begun to try out git-subrepo, the chances I got something wrong are high.

rendered

closes #629

Copy link
Collaborator

@admorgan admorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to complement you on a very nice job, notably improving the documentation for this project. I really appreciate it. I do have some nit picks, but I couldn't have done this well myself.

@abeforgit
Copy link
Contributor Author

Oh this dropped off my radar, busy week
But thank you for the feedback, some good points, I'll update asap

@abeforgit abeforgit force-pushed the docs/add-info-about-nested-subrepos branch from 3a0c73a to 46dc432 Compare August 31, 2024 16:56
@abeforgit abeforgit requested a review from admorgan August 31, 2024 16:56
@abeforgit
Copy link
Contributor Author

I think I (finally 🙈) addressed all your remarks, let me know if you want me to change something about the "final step"

admorgan pushed a commit to admorgan/git-subrepo that referenced this pull request Feb 9, 2025
@admorgan admorgan closed this in b9b059a Feb 9, 2025
@admorgan admorgan closed this in #644 Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document intended usage with nested subrepos
2 participants