Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add client error `Too_many_requests #135

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vbmithr
Copy link
Contributor

@vbmithr vbmithr commented Jul 6, 2019

No description provided.

@seliopou
Copy link
Member

Which RFC does this come from? The one's explicitly mentioned in the Status module are the ones described in RFC7231§6.

@vbmithr
Copy link
Contributor Author

vbmithr commented Jul 21, 2019

@sazarkin
Copy link

Maybe we should add all of them from rfc6585

  • 428 Precondition Required
  • 429 Too Many Requests
  • 431 Request Header Fields Too Large
  • 511 Network Authentication Required

@vbmithr
Copy link
Contributor Author

vbmithr commented Nov 8, 2020

@seliopou @sazarkin

What do you guys want to do with statuses from newer RFCs? Merge them, or just continue to use ``Code x`? I'm fine with both solutions, but please process those PRs either by closing them or merging them.

@somebody1234
Copy link

also worth noting that there's also rfc4918 - which has `Unprocessable_entity (#191) which is useful for requests that are syntactically well-formed (?) but semantically wrong

of course, it's worth noting that the official status of both are proposed standards so maybe they shouldn't be added - however it's also very unlikely that the same codes will be reused for a different purpose.

also MDN lists them, and httpaf already includes other non-rfc7231 status codes like `I_m_a_teapot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants