-
-
Notifications
You must be signed in to change notification settings - Fork 242
feat: switch to ESM-only #1411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: switch to ESM-only #1411
Conversation
I am 👍 to esm only |
@fb55 if i can get a thumbs up from you too, ill merge and publish this under a new major version |
I am unable to go ESM-only with Cheerio right now, so would prefer to keep the CJS build |
are you on node also, unless you see us adding features, you could just stick to the current version, no? it seems unlikely we'd change API, so won't have anything in the new major that the old one doesn't have already |
@fb55 can we discuss this? I'm in the process of migrating a lot of other packages I maintain to esm-only. so it'd be good to wrap this one up one way or another if you still need CJS, that's what the old version is for since its unlikely we'll add any features any time soon. if somehow there is a fix, we can backport it if needed we don't need to be afraid of major versions. its ok to continue using the previous one in cheerio |
Also #1410 is now unblocked and could land in the current major, so in addition to feature parity, the dependencies won't stay behind. |
@fb55 maybe lets revisit this? my plan would be this now:
|
Switches the 3 remaining dual packages to ESM only: - `parse5-htmlparser2-tree-adapter` - `parse5-parser-stream` - `parse5`
Switches the 3 remaining dual packages to ESM only:
parse5-htmlparser2-tree-adapter
parse5-parser-stream
parse5
NOTE: we still haven't decided if we are ready to do this yet. just leaving this draft here for when we do one day