added docker support and debounce logic on door open button #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user890104
requested changes
May 10, 2024
| @@ -4,7 +4,7 @@ | |||
| "version": "0.0.0", | |||
| "type": "module", | |||
| "scripts": { | |||
| "dev": "vite", | |||
| "dev": "vite --no-open --host 0.0.0.0", | |||
There was a problem hiding this comment.
Please move these parameters to Dockerfile CMD line
| @@ -50,15 +51,19 @@ const DeviceActionButton = ({ | |||
| icon: '', | |||
| }; | |||
|
|
|||
| const openDoor = debounce(execute, 2000); | |||
There was a problem hiding this comment.
Please keep the timeout at 3000, since the door mechanisms are open for at least 3 seconds and there is no reason to request opening again. Also this is a generic function that is used for both doors and lights (and other things in the future) so please either use a more generic name like executeDelayed or limit debouncing to just the door device type.
Comment on lines
+59
to
+62
| // await execute({ | ||
| // deviceId, | ||
| // action, | ||
| // }); |
There was a problem hiding this comment.
Please remove the old code, it can be easily recovered from the Git history.
|
|
||
| await sleep(3000); | ||
| // await sleep(3000); |
| @@ -0,0 +1 @@ | |||
| COMPOSE_PROJECT_NAME=space-initlab | |||
There was a problem hiding this comment.
Please add a new line at the end of the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.