disallow "hook" at validate

initia-labs · Sep 17, 2024 · fb22529 · fb22529
1 parent e9f4748
commit fb22529
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/x/opchild/types/tx.go b/x/opchild/types/tx.go
@@ -251,11 +251,8 @@ func (msg MsgFinalizeTokenDeposit) Validate(ac address.Codec) error {
 		return sdkerrors.ErrInvalidAddress.Wrap("from address cannot be empty")
 	}
 
-	// allow hook as a special address
-	if msg.To != "hook" {
-		if _, err := ac.StringToBytes(msg.To); err != nil {
-			return err
-		}
+	if _, err := ac.StringToBytes(msg.To); err != nil {
+		return err
 	}
 
 	// allow zero amount

diff --git a/x/ophost/keeper/msg_server_test.go b/x/ophost/keeper/msg_server_test.go
@@ -163,7 +163,7 @@ func Test_InitiateTokenDeposit(t *testing.T) {
 	input.Faucet.Fund(ctx, addrs[1], amount)
 	_, err = ms.InitiateTokenDeposit(
 		ctx,
-		types.NewMsgInitiateTokenDeposit(addrsStr[1], 1, "hook", amount, []byte("messages")),
+		types.NewMsgInitiateTokenDeposit(addrsStr[1], 1, "l2_addr", amount, []byte("messages")),
 	)
 	require.NoError(t, err)
 	require.True(t, input.BankKeeper.GetBalance(ctx, addrs[1], sdk.DefaultBondDenom).IsZero())