Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/rollback #38

Merged
merged 20 commits into from
Apr 3, 2024
Merged

Feat/rollback #38

merged 20 commits into from
Apr 3, 2024

Conversation

sh-cha
Copy link
Contributor

@sh-cha sh-cha commented Mar 29, 2024

No description provided.

@sh-cha sh-cha requested a review from beer-1 March 29, 2024 07:18
@sh-cha sh-cha requested a review from a team as a code owner March 29, 2024 07:18
@sh-cha
Copy link
Contributor Author

sh-cha commented Apr 1, 2024

WIP: need to write readme & env sample about batch submitter

bots/src/celestia/utils.ts Outdated Show resolved Hide resolved
bots/src/celestia/utils.ts Outdated Show resolved Hide resolved
bots/src/celestia/utils.ts Outdated Show resolved Hide resolved
bots/src/celestia/utils.ts Outdated Show resolved Hide resolved
bots/src/celestia/utils.ts Outdated Show resolved Hide resolved
beer-1 and others added 4 commits April 2, 2024 20:05
* register denom metadata

* fix tests

* register base denom and fix claim response

* add l1 denom in resurrector

* add executor monitor start height

* bug fix: add fee param as undefined to adjust sendtx change

* delete output proposal only if it is not finalized

* add tests

* add tests and minor type fixes

* validate bridge config before update

* enforce to set batch info

* fix error message

* cleanup

---------

Co-authored-by: JSHan94 <[email protected]>
Co-authored-by: ALPAC-4 <[email protected]>
Co-authored-by: hoon <[email protected]>
Copy link
Member

@beer-1 beer-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 31.98381% with 168 lines in your changes are missing coverage. Please review.

Project coverage is 55.69%. Comparing base (8e6f980) to head (8e8060c).
Report is 8 commits behind head on main.

❗ Current head 8e8060c differs from pull request most recent head 096484b. Consider uploading reports for the commit 096484b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
- Coverage   58.10%   55.69%   -2.41%     
==========================================
  Files          23       30       +7     
  Lines        1475     2361     +886     
==========================================
+ Hits          857     1315     +458     
- Misses        437      788     +351     
- Partials      181      258      +77     
Files Coverage Δ
x/opchild/keeper/keeper.go 81.35% <100.00%> (+0.99%) ⬆️
x/ophost/client/cli/tx.go 62.18% <100.00%> (ø)
x/opchild/keeper/val_state_change.go 52.38% <40.00%> (-1.95%) ⬇️
x/ophost/keeper/bridge.go 50.98% <0.00%> (-3.19%) ⬇️
x/ophost/keeper/querier.go 76.28% <66.66%> (-0.99%) ⬇️
x/opchild/keeper/historical_info.go 47.61% <16.66%> (-1.22%) ⬇️
x/ophost/keeper/output.go 57.74% <59.09%> (+0.60%) ⬆️
x/ophost/keeper/msg_server.go 59.39% <63.79%> (+0.56%) ⬆️
x/opchild/keeper/executor_change.go 26.31% <26.31%> (ø)
x/opchild/client/cli/genesis.go 0.00% <0.00%> (ø)

... and 4 files with indirect coverage changes

@beer-1 beer-1 merged commit 26ed9a5 into main Apr 3, 2024
1 check passed
@beer-1 beer-1 deleted the feat/rollback branch April 3, 2024 10:21
@sh-cha sh-cha self-assigned this Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants