Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kvindexer #22

Merged
merged 80 commits into from
Apr 18, 2024
Merged

add kvindexer #22

merged 80 commits into from
Apr 18, 2024

Conversation

Vritra4
Copy link
Contributor

@Vritra4 Vritra4 commented Apr 16, 2024

No description provided.

@Vritra4 Vritra4 requested a review from beer-1 April 16, 2024 08:32
@Vritra4 Vritra4 self-assigned this Apr 16, 2024
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 43.83562% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 58.51%. Comparing base (93aad48) to head (d15869f).

Files Patch % Lines
app/app.go 46.37% 34 Missing and 3 partials ⚠️
cmd/minitiad/config.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   58.87%   58.51%   -0.36%     
==========================================
  Files          15       15              
  Lines        1527     1591      +64     
==========================================
+ Hits          899      931      +32     
- Misses        598      627      +29     
- Partials       30       33       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@beer-1 beer-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vritra4 Vritra4 merged commit 637b503 into main Apr 18, 2024
4 of 6 checks passed
@Vritra4 Vritra4 deleted the indexer-v2 branch April 18, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants