Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade: prepare v0.6.3 #75

Merged
merged 2 commits into from
Nov 15, 2024
Merged

upgrade: prepare v0.6.3 #75

merged 2 commits into from
Nov 15, 2024

Conversation

beer-1
Copy link
Contributor

@beer-1 beer-1 commented Nov 15, 2024

Description

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

Release Notes

  • New Features

    • Updated the AnteHandler creation process for improved argument handling.
    • Introduced a conditional check for the HookMaxGas parameter during upgrades.
  • Bug Fixes

    • Enhanced error handling for parameter updates in the upgrade process.
  • Chores

    • Updated dependencies and toolchain versions for improved compatibility and security.

@beer-1 beer-1 self-assigned this Nov 15, 2024
@beer-1 beer-1 requested a review from a team as a code owner November 15, 2024 08:51
Copy link

coderabbitai bot commented Nov 15, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request includes modifications to the NewAnteHandler function in app/ante/ante.go, simplifying the argument handling for the auctionante.NewAuctionDecorator. The upgrade version in app/upgrade.go is updated from "0.6.2" to "0.6.3", introducing conditional logic for the HookMaxGas parameter. Additionally, the go.mod file is updated to reflect new dependency versions and a new Go toolchain version, ensuring compatibility and addressing potential security concerns.

Changes

File Change Summary
app/ante/ante.go - Modified NewAnteHandler: changed AuctionKeeper argument from dereferenced to pointer.
- No changes to CreateAnteHandlerForOPinit.
app/upgrade.go - Updated upgrade version from "0.6.2" to "0.6.3".
- Altered HookMaxGas parameter handling to check for zero before assigning default value.
go.mod - Updated github.com/initia-labs/OPinit and api dependencies from v0.5.7 to v0.6.0.
- Updated toolchain version from go1.22.7 to go1.23.0.
- Adjusted various dependencies to specific versions or forks.

Possibly related PRs

  • fix: enable ethpubkey #68: This PR modifies the NewAnteHandler function in the app/ante/ante.go file, specifically changing the instantiation of the signature verification decorator, which is closely related to the changes made in the main PR regarding the NewAnteHandler function.

Suggested reviewers

  • sh-cha

Poem

In the code where rabbits play,
Changes hop in a bright array.
AnteHandler's path now clear,
Upgrades leap with cheer,
Dependencies dance, all in sway,
A joyful code, come what may! 🐇✨

Warning

Rate limit exceeded

@beer-1 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 14 minutes and 0 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 00edbc4 and bc02feb.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.

Project coverage is 77.29%. Comparing base (00edbc4) to head (bc02feb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
app/upgrade.go 0.00% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #75   +/-   ##
=======================================
  Coverage   77.29%   77.29%           
=======================================
  Files          14       14           
  Lines        1414     1414           
=======================================
  Hits         1093     1093           
  Misses        271      271           
  Partials       50       50           
Files with missing lines Coverage Δ
app/ante/ante.go 58.20% <100.00%> (ø)
app/upgrade.go 20.00% <0.00%> (ø)

Copy link
Contributor

@sh-cha sh-cha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beer-1 beer-1 merged commit 49d0d7f into main Nov 15, 2024
11 of 13 checks passed
@beer-1 beer-1 deleted the release/v0.6.3 branch November 15, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants