Fixed another typo #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A systemd definition requires the identification of a given Service, whether it is a service or a socket, etc. This bugfix fixes inkatze#8. But there are more things to do. The init script allowed for a lot more options, which need to be ported into the systemd script. I think the easiest would be to call the init script with the start option from the service definition file. Let me know what you think.
|
Please, go ahead if you want. The reason the systemd file is so weird is because it wasn't originally supported by the role. It was added in a recent commit that looked small enough to not cause any harm, but I was mistaken. So yeah, I will appreciate if you use the systemd file provided by wildfly, but in that case I don't know if you'd want to close this pull request and fix these typos later; let me know. |
inkatze
approved these changes
Nov 29, 2016
|
Created #16 to keep track of this issue. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some more issues with the systemd change. Is there a reason, why you are not using the systemd file provided with wildfly under
{{WILDFLY_HOME}}/docs/contrib/scripts/systemd/? If you are ok with it, I would change the role to include that service, because it would then allow to pull in the details from wildfly.conf as with the init file.