fix: update HasFunction method to discern between regular knots and function knots. #927
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
For detailed information on the problem, please see the issue posted here:
#928
In short, the issue seems to be that
Story.cs
's methodHasFunction
doesn't discern between regular knots and function knots. It calls uponKnotContainerWithName
to check if the container is there, but this doesn't distinguish function knots.Solution:
Debugging and looking at the structure of a regular knot vs function knot
Container
object, the only difference I can note is that function knots contain aPopFunction
command at the end of their contents. I've leveraged this for a (hacky) fix to check if the knot container retrieved is indeed a function.If you know of a better way to do this, please make a suggestion!