fix: remove timestamp restriction on registerFeedback (#82)

inloco · Jul 24, 2024 · 8c34eda · 8c34eda
1 parent d51499e
commit 8c34eda
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 7 deletions.
diff --git a/src/incogniaApi.ts b/src/incogniaApi.ts
@@ -130,9 +130,9 @@ export class IncogniaApi {
     bodyParams: RegisterFeedbackBodyProps,
     queryParams?: RegisterFeedbackParamsProps
   ): Promise<void> {
-    const { event, timestamp } = bodyParams || {}
-    if (!event || !timestamp) {
-      throw new IncogniaError('No event or timestamp provided')
+    const { event } = bodyParams || {}
+    if (!event) {
+      throw new IncogniaError('No event provided')
     }
 
     const params = queryParams && convertObjectToSnakeCase(queryParams)

diff --git a/test/incogniaApi.test.ts b/test/incogniaApi.test.ts
@@ -228,9 +228,40 @@ describe('API', () => {
 
         await incogniaApi.registerFeedback(
           {
-            installationId: 'installation_id',
-            accountId: 'account_id',
+            event: FeedbackEvent.AccountTakeover
+          },
+          {
+            dryRun: true
+          }
+        )
+
+        const expectedData = {
+          event: FeedbackEvent.AccountTakeover,
+        }
+
+        const expectedParams = {
+          dry_run: true
+        }
+
+        expect(incogniaApi.resourceRequest).toBeCalledWith({
+          url: apiEndpoints.FEEDBACKS,
+          method: 'post',
+          params: expectedParams,
+          data: expectedData
+        })
+      })
+
+      it('registers feedback when all params are filled', async () => {
+        incogniaApi.resourceRequest = vi.fn()
+
+        await incogniaApi.registerFeedback(
+          {
             event: FeedbackEvent.AccountTakeover,
+            accountId: 'account_id',
+            installationId: 'installation_id',
+            loginId: 'login_id',
+            paymentId: 'payment_id',
+            signupId: 'signup_id',
             timestamp: 123
           },
           {
@@ -239,9 +270,12 @@ describe('API', () => {
         )
 
         const expectedData = {
-          installation_id: 'installation_id',
-          account_id: 'account_id',
           event: FeedbackEvent.AccountTakeover,
+          account_id: 'account_id',
+          installation_id: 'installation_id',
+          login_id: 'login_id',
+          payment_id: 'payment_id',
+          signup_id: 'signup_id',
           timestamp: 123
         }