Remove getSignupAssessment method

README.md

@@ -78,19 +78,6 @@ try {
 }
 ```
 
-
-### Getting a Mobile Signup
-
-This method allows you to retrieve the latest assessment for a given signup event, returning a signup assessment, containing the risk assessment and supporting evidence:
-
-```js
-try {
-  const signupAssessment = await incogniaApi.getSignupAssessment(signupId)
-} catch (error) {
-  console.log(error.message)
-}
-```
-
 ### Registering a Mobile Login
 
 This method registers a new mobile login for the given installation and account, returning a transaction assessment, containing the risk assessment and supporting evidence.

package.json

@@ -2,7 +2,7 @@
   "name": "@incognia/api",
   "author": "Incognia (https://us.incognia.com)",
   "repository": "https://github.com/inloco/incognia-node",
-  "version": "4.5.1",
+  "version": "5.0.0",
   "license": "MIT",
   "type": "module",
   "main": "dist/index.cjs.js",

src/incogniaApi.ts

@@ -77,17 +77,6 @@ export class IncogniaApi {
   /*
    ** Resources
    */
-  async getSignupAssessment(signupId: string): Promise<SignupResponse> {
-    if (!signupId) {
-      throw new IncogniaError('No signupId provided')
-    }
-
-    return this.resourceRequest({
-      url: `${apiEndpoints.SIGNUPS}/${signupId}`,
-      method: Method.Get
-    })
-  }
-
   async registerSignup(props: RegisterSignupProps): Promise<SignupResponse> {
     const { installationId } = props || {}
     if (!installationId) {

src/version.ts

@@ -1,2 +1,2 @@
 // Generated by genversion.
-export const version = '4.5.1'
+export const version = '5.0.0'

test/incogniaApi.test.ts

@@ -75,30 +75,6 @@ describe('API', () => {
       })
     })
 
-    it('gets signup assessment', async () => {
-      const apiResponse = {
-        id: '5e76a7ca-577c-4f47-a752-9e1e0cee9e49',
-        request_id: '8afc84a7-f1d4-488d-bd69-36d9a37168b7',
-        risk_assessment: 'low_risk'
-      }
-
-      const expectedResponse = {
-        id: '5e76a7ca-577c-4f47-a752-9e1e0cee9e49',
-        requestId: '8afc84a7-f1d4-488d-bd69-36d9a37168b7',
-        riskAssessment: 'low_risk'
-      }
-
-      nock(BASE_ENDPOINT_URL)
-        .get(`/v2/onboarding/signups/${apiResponse.id}`)
-        .reply(200, apiResponse)
-
-      const signupAssessment = await incogniaApi.getSignupAssessment(
-        apiResponse.id
-      )
-
-      expect(signupAssessment).toEqual(expectedResponse)
-    })
-
     it('registers signup', async () => {
       const apiResponse = {
         id: '5e76a7ca-577c-4f47-a752-9e1e0cee9e49',
@@ -366,25 +342,29 @@ describe('API', () => {
 
     describe('when calling the api ', () => {
       it('calls access token endpoint only at the first time', async () => {
-        const signupId = '123'
         const accessTokenEndpointFirstCall = nock(BASE_ENDPOINT_URL)
           .post('/v2/token')
           .reply(200, accessTokenExample)
-        const signupEndpointGet = nock(BASE_ENDPOINT_URL)
+        const signupEndpointRegister = nock(BASE_ENDPOINT_URL)
           .persist()
-          .get(`/v2/onboarding/signups/${signupId}`)
+          .post(`/v2/onboarding/signups`)
           .reply(200)
         const accessTokenEndpointSecondCall = nock(BASE_ENDPOINT_URL)
           .post('/v2/token')
           .reply(200, accessTokenExample)
 
+        const payload = {
+          installationId: 'installation_id',
+          policyId: 'policy_id'
+        }
+
         //call resource for the first time
-        await incogniaApi.getSignupAssessment(signupId)
+        await incogniaApi.registerSignup(payload)
         expect(accessTokenEndpointFirstCall.isDone()).toBeTruthy()
-        expect(signupEndpointGet.isDone()).toBeTruthy()
+        expect(signupEndpointRegister.isDone()).toBeTruthy()
 
         //call resource for the second time
-        await incogniaApi.getSignupAssessment(signupId)
+        await incogniaApi.registerSignup(payload)
         expect(accessTokenEndpointSecondCall.isDone()).toBeFalsy()
       })
     })