Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add missing fields to registerFeedback #83

Merged
merged 1 commit into from
Jul 24, 2024
Merged

feat: add missing fields to registerFeedback #83

merged 1 commit into from
Jul 24, 2024

Conversation

figueredo
Copy link
Contributor

@figueredo figueredo commented Jul 18, 2024 •
edited
Loading

Adds sessionToken, requestToken and expiresAt to registerFeedback.

@figueredo figueredo self-assigned this Jul 18, 2024
@figueredo figueredo force-pushed the feat-feedback-missing-fields branch from c5abe89 to cfe6ef6 Compare July 18, 2024 01:04
@figueredo figueredo changed the title Add RFC 3339 date fields Add missing fields to registerFeedback Jul 18, 2024
@figueredo figueredo changed the base branch from fix-feedback-remove-timestamp-restriction to feat-rfc3339-fields July 18, 2024 01:05
@figueredo figueredo changed the title Add missing fields to registerFeedback feat: add missing fields to registerFeedback Jul 18, 2024
@figueredo figueredo force-pushed the feat-rfc3339-fields branch from d74eabf to b65739e Compare July 19, 2024 19:53
@figueredo figueredo force-pushed the feat-feedback-missing-fields branch from cfe6ef6 to 23343f8 Compare July 19, 2024 19:55
@figueredo figueredo force-pushed the feat-rfc3339-fields branch from b65739e to 6b17227 Compare July 24, 2024 13:30
Base automatically changed from feat-rfc3339-fields to master July 24, 2024 13:35
@figueredo
feat: add missing fields to registerFeedback
f2711ab 
Adds sessionToken, requestToken and expiresAt.
@figueredo figueredo force-pushed the feat-feedback-missing-fields branch from 23343f8 to f2711ab Compare July 24, 2024 13:37
@figueredo figueredo merged commit 38e803e into master Jul 24, 2024
4 checks passed
@figueredo figueredo deleted the feat-feedback-missing-fields branch July 24, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelscr marcelscr marcelscr approved these changes

@FranciscoGileno FranciscoGileno FranciscoGileno approved these changes

@julianalucena julianalucena Awaiting requested review from julianalucena julianalucena is a code owner

@ottony ottony Awaiting requested review from ottony ottony is a code owner

Assignees

@figueredo figueredo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@figueredo @FranciscoGileno @marcelscr