feat: add RFC 3999 fields that replace timestamps #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
figueredo
requested review from
FranciscoGileno,
julianalucena,
ottony and
marcelscr
as code owners
marcelscr
approved these changes
Jul 18, 2024
figueredo
changed the title
figueredo
force-pushed
the
fix-feedback-remove-timestamp-restriction
branch
from
ee797ee to
49a8828
Compare
figueredo
force-pushed
the
feat-rfc3339-fields
branch
from
d74eabf to
b65739e
Compare
FranciscoGileno
approved these changes
Jul 22, 2024
Base automatically changed from
fix-feedback-remove-timestamp-restriction
to
master
July 24, 2024 13:26
figueredo
force-pushed
the
feat-rfc3339-fields
branch
from
b65739e to
6b17227
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three fields were added to the API to replace existing
timestampfields, two of them are present in this library:timestampis being replaced byoccurred_at;location.timestampis being replaced bylocation.collected_at.In these new fields, the date is formatted as a RFC 3339 string, e.g. '2024-07-17T01:02:03Z'. This PR adds the new fields and marks the existing ones as deprecated.