[5.2.0] feat(RequestToken): add request_token support to all methods #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelscr
requested review from
FranciscoGileno,
julianalucena and
ottony
as code owners
marcelscr
commented
Aug 5, 2024
| @@ -114,7 +120,52 @@ describe('API', () => { | |||
| expect(signup).toEqual(expectedResponse) | |||
| }) | |||
|
|
|||
| it('registers a web signup', async () => { | |||
| it('registers signup with request_token', async () => { | |||
There was a problem hiding this comment.
Esses testes ficaram meio replicados nessa versão, mas eles já mudaram completamente no PR do 6 (singleton). Estou adicionando aqui as validações que ainda não existiam.
marcelscr
changed the title
leonardoAnjos16
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Esse PR adiciona o suporte para recebimento do
request_tokencomo substituto doinstallation_idesession_tokenem todos os métodos. Como não queremos fazer uma mudança quebrante, oinstallation_idesession_tokenpermanecem como alternativas - mas deixam de ser obrigatórios.