Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: remove invalid feedback types and add missing ones #59

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

figueredo
Copy link
Contributor

Removes no-longer valid feedback types and adds missing ones.

This is a breaking change.

@figueredo figueredo requested a review from b0rba July 18, 2024 18:03
@figueredo figueredo self-assigned this Jul 18, 2024
@figueredo figueredo requested a review from a team as a code owner July 18, 2024 18:03
@figueredo figueredo requested review from edenalsant and removed request for a team July 18, 2024 18:03
Copy link
Contributor

@b0rba b0rba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could make two releases.
One with the other two changes together. And the second one, as a major change and a new release;

@figueredo figueredo force-pushed the feat-feedback-missing-fields branch from 06270b2 to de80bb3 Compare July 19, 2024 20:23
@figueredo figueredo force-pushed the fix-feedback-remove-invalid-types branch from 6a371ba to 32ec4cb Compare July 19, 2024 20:24
@figueredo figueredo force-pushed the feat-feedback-missing-fields branch from de80bb3 to 2778c2f Compare July 19, 2024 20:30
@figueredo figueredo force-pushed the fix-feedback-remove-invalid-types branch 2 times, most recently from 5518ebe to 6057fed Compare July 20, 2024 04:32
@figueredo figueredo force-pushed the feat-feedback-missing-fields branch from 2778c2f to b64fe20 Compare July 24, 2024 12:25
Base automatically changed from feat-feedback-missing-fields to main July 24, 2024 12:27
@figueredo figueredo force-pushed the fix-feedback-remove-invalid-types branch from 6057fed to 1bfcbef Compare July 24, 2024 12:28
Copy link

@edenalsant edenalsant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it have a version bump to 3.0.0?

@edenalsant
Copy link

Shouldn't it have a version bump to 3.0.0?

resolved

@aninhalbuquerque aninhalbuquerque force-pushed the fix-feedback-remove-invalid-types branch from 1bfcbef to 5679636 Compare September 20, 2024 17:27
@aninhalbuquerque aninhalbuquerque merged commit 6233669 into main Sep 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants