Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README.md #9

wants to merge 1 commit into from

Conversation

atom-box
Copy link

@atom-box atom-box commented Apr 21, 2023 •
edited
Loading

One customer (as well as myself) did not immediately realize that this script is only for plugins subscribers. They wrote to us and asked "How come we are running this and it is asking for a key. What key is that?" (Customer has no plugins subscriptions and lost 8 days to our back and forth on this issue.)

Description:

I only added language that clarifies: "this script is for plugins subscribers - other users should employ a different method".

Review

  • Functional review done
  • Potential edge cases thought about (behavior of the code with strange input, with strange internal state or possible interactions with other Matomo subsystems)
  • Usability review done (is anything maybe unclear or think about anything that would cause people to reach out to support)
  • Security review done see checklist
  • Code review done
  • Tests were added if useful/possible
  • Reviewed for breaking changes
  • Developer changelog updated if needed
  • Documentation added if needed
  • Existing documentation updated if needed

@atom-box
Update README.md
7ebcc4a 
One customer (as well as myself) did not immediately realize that this script is only for plugins subscribers. They wrote to us and asked "How come we are running this and it is asking for a key. What key is that?" (Customer has no plugins subscriptions and lost 8 days to our back and forth on this issue.)  

My edit adds clarity: "this script is for plugins subscribers".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@atom-box