Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: #187 package version #188

Merged
merged 11 commits into from
Dec 9, 2023
Merged

chore: #187 package version #188

merged 11 commits into from
Dec 9, 2023

Conversation

niamu01
Copy link
Collaborator

@niamu01 niamu01 commented Dec 6, 2023

์ˆ˜์ • ๋ฐ ์ž‘์—… ๋‚ด์šฉ

  1. ํŒจํ‚ค์ง€๋“ค wanted ๋ฒ„์ „์œผ๋กœ ์˜ฌ๋ฆฌ๊ธฐ
    wanted is the maximum version of the package that satisfies the semver range specified in package.json
    https://docs.npmjs.com/cli/v10/commands/npm-outdated

  2. npm audit report์— ์ทจ์•ฝ์ ์œผ๋กœ ํ‘œ์‹œ๋˜๋Š” 13 vulnerabilities (8 moderate, 5 critical) ์ค‘
    a. @nestjs/[email protected] ์œผ๋กœ 2 moderate ํ•ด๊ฒฐ
    b. @nestjs/[email protected] ์œผ๋กœ 2 critical ํ•ด๊ฒฐ
    c. @nestjs/[email protected] ์œผ๋กœ 1 moderate ํ•ด๊ฒฐ
    d. @nestjs/[email protected] ์œผ๋กœ 2 moderate ํ•ด๊ฒฐ
    e. ์—ฌ๊ธฐ๋ถ€ํ„ฐ ์„œ๋กœ ์˜์กด์„ฑ์ด ์žˆ์–ด force๋กœ ์ง„ํ–‰
    f. @nestjs/[email protected] --force ์œผ๋กœ 3 moderate ํ•ด๊ฒฐ
    g.@nestjs/[email protected] --force 3 critical ํ•ด๊ฒฐ
    h. ์ดํ›„ ์—๋Ÿฌ์ฝ”๋“œ ์ฝ์œผ๋ฉฐ ์„ค์น˜ (notion์— ์ž์„ธํ•œ ์‚ฌํ•ญ ๊ธฐ๋ก)
    https://www.notion.so/nimble-ceder-40b/npm-f69b6d4e27d645b392940b643a07a946

  3. @nestjs/common ์—…๋ฐ์ดํŠธ ์ด์Šˆ ํ•ด๊ฒฐ
    cache-manager module for Nest originally published as part of the @nestjs/common package. This package is a drop-in replacement for the deprecated CacheModule.
    https://www.npmjs.com/package/@nestjs/cache-manager

  4. cache-manager ์—…๋ฐ์ดํŠธ ์ด์Šˆ ํ•ด๊ฒฐ
    4.1.0 -> 5.3.1 ๋กœ ๋ฐ”๋€Œ๋ฉด์„œ TTL์˜ ๊ฐ’์„ ์ˆ˜์ •ํ•˜์˜€์Šต๋‹ˆ๋‹ค.
    https://docs.nestjs.com/techniques/caching

  5. ์ดํ›„ ํŒจํ‚ค์ง€ ๋ณ„ ๊ณต์‹ ๋ฌธ์„œ ๋‚ด release notes ํ™•์ธ ํ›„ ๋ชจ๋‘ ์ตœ์‹  ํŒจํ‚ค์ง€๋กœ ์—…๋ฐ์ดํŠธ
    https://www.notion.so/nimble-ceder-40b/npm-121f546a79ea4c1e896bf58f104d21d2

์‚ฌ์œ 

  • npm update && npm i ์‹œ ํŒจํ‚ค์ง€ ๋ฒ„์ „ ์ถฉ๋Œ

ํ…Œ์ŠคํŠธ

  • docker-compose up, npm run start:dev ๋™์ž‘ ํ™•์ธ
  • npm outdated, npm audit ํ•ด๋ณด์‹ญ์‡ผ ํ•˜ํ•˜

@nestjs/common์— ์žˆ๋˜ cache-manager ๋ชจ๋“ˆ์ด ๋ฒ„์ „ ์—…๋ฐ์ดํŠธ์—์„œ ๋ถ„๋ฆฌ๋˜์–ด ์„ค์น˜ํ•ด์ฃผ์—ˆ์Šต๋‹ˆ๋‹ค.
deprecated ๋œ CacheModule์„ ์‚ฌ์šฉํ•  ์ˆ˜ ์žˆ๊ฒŒ ํ•ด์ค๋‹ˆ๋‹ค.
@niamu01 niamu01 force-pushed the chore-packageVersion-#187 branch from 4ca5f3f to 6022181 Compare December 6, 2023 16:59
cache-manager ์˜ ๋ฒ„์ „์ด 4์—์„œ 5๋กœ ์˜ฌ๋ผ๊ฐ€๋ฉฐ ttl์˜ ๋‹จ์œ„๊ฐ€ seconds -> milliseconds ๋กœ ๋ฐ”๋€Œ์–ด ๋ณ€๊ฒฝํ•˜์˜€์Šต๋‹ˆ๋‹ค.
@niamu01 niamu01 self-assigned this Dec 8, 2023
@niamu01 niamu01 requested a review from enaenen December 8, 2023 04:45
Copy link
Collaborator

@enaenen enaenen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm ๋ช…๋ น์–ด๋“ค๋กœ ํ•ด๊ฒฐ๋˜๋Š” ์ƒํ™ฉ์ด์—ˆ๋‚˜์š”? ์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค! ๐Ÿ‘

@niamu01 niamu01 linked an issue Dec 8, 2023 that may be closed by this pull request
@niamu01 niamu01 merged commit ff6eda8 into develop Dec 9, 2023
3 checks passed
@niamu01 niamu01 deleted the chore-packageVersion-#187 branch December 9, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

๐Ÿงฑ package version
2 participants