feat(client): 백엔드 api를 사용하여 프리셋 저장, 수정, 삭제 #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 7, 2022 17:01
- 백엔드 api를 사용하여 preset을 삭제할 수 있는 버튼을 만들었습니다 feat #368
xhseb
force-pushed
the
feat/presetstorage
branch
from
a828304 to
3b87ea5
Compare
HyeonsikBae
approved these changes
Aug 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 동기 (Motivation)
변경 사항 요약 (Key changes)
체크리스트
스크린샷 첨부
리뷰어들에게 요청사항
아직 dashboard42.com으로 프리셋 api가 되지 않기 때문에 임시로 로컬에 백엔드 서버를 올려서 완성하였습니다. 추후 도메인에 프리셋 api가 사용 가능할 때 붙이도록 하겠습니다!
usePreset에서 deletePreset 함수를 만들고 싶었는데 usePreset 내에서 무한 렌더링이되어 임시로 useBoard에 만들었습니다.
추후 수정되어야 할 사항입니다.
#368