Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FE] FEAT : profile layout #1389

Merged
merged 4 commits into from
Oct 13, 2023
Merged

[FE] FEAT : profile layout #1389

merged 4 commits into from
Oct 13, 2023

Conversation

seong-hui
Copy link
Collaborator

해당 사항 (중복 선택)

  • FEAT : 새로운 기능 추가 및 개선
  • FIX : 기존 기능 수정 및 정상 동작을 위한 간단한 추가, 수정사항
  • BUG : 버그 수정
  • REFACTOR : 결과의 변경 없이 코드의 구조를 재조정
  • TEST : 테스트 코드 추가
  • DOCS : 코드가 아닌 문서를 수정한 경우
  • REMOVE : 파일을 삭제하는 작업만 수행
  • RENAME : 파일 또는 폴더명을 수정하거나 위치(경로)를 변경
  • ETC : 이외에 다른 경우 - 어떠한 사항인지 작성해주세요.

설명

아래 링크에 이슈번호를 적어주세요. 예) .../42cabi/issues/738

#1388
image
image

  • 프로필 페이지가 생김에 따라 수정된 레이아웃 구조를 변경했습니다.
  • 기존의 LeftSection에 profile페이지인지를 확인해서 프로필 섹션이 보이도록 구조를 수정하였습니다.

@seong-hui seong-hui added FEAT New feature or upgrade FE Frontend tasks labels Sep 21, 2023
@seong-hui seong-hui self-assigned this Sep 21, 2023
junyoung2015
junyoung2015 approved these changes Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@junyoung2015 junyoung2015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

레이아웃 하느라 고생하셨습니다. LGTM!

YESHYUNGSEOK
YESHYUNGSEOK reviewed Sep 22, 2023
View reviewed changes
Copy link
Collaborator

@YESHYUNGSEOK YESHYUNGSEOK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 💪 Layout부터 LeftSectionNav까지 전달되는 isVisible과 isProfile 프로퍼티가 불필요한 prop drilling이 있어 보이는데, 이 부분을 개선해보는 건 어떨까 싶습니다!!

@YESHYUNGSEOK YESHYUNGSEOK merged commit 5331370 into dev Oct 13, 2023
2 checks passed
@YESHYUNGSEOK YESHYUNGSEOK deleted the fe/dev/feat_profile_layout branch October 13, 2023 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YESHYUNGSEOK YESHYUNGSEOK YESHYUNGSEOK left review comments

@junyoung2015 junyoung2015 junyoung2015 approved these changes

@42inshin 42inshin Awaiting requested review from 42inshin

Assignees

@seong-hui seong-hui

Labels
FE Frontend tasks FEAT New feature or upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seong-hui @junyoung2015 @YESHYUNGSEOK