Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] HOTFIX - deleted_at 제거 및 로직 변경, 반영 #1461

Merged
merged 3 commits into from
Nov 30, 2023
Merged

[BE] HOTFIX - deleted_at 제거 및 로직 변경, 반영 #1461

merged 3 commits into from
Nov 30, 2023

Conversation

Ssuamje
Copy link
Collaborator

@Ssuamje Ssuamje commented Nov 30, 2023

해당 사항 (중복 선택)

  • FEAT : 새로운 기능 추가 및 개선
  • FIX : 기존 기능 수정 및 정상 동작을 위한 간단한 추가, 수정사항
  • BUG : 버그 수정
  • REFACTOR : 결과의 변경 없이 코드의 구조를 재조정
  • TEST : 테스트 코드 추가
  • DOCS : 코드가 아닌 문서를 수정한 경우
  • REMOVE : 파일을 삭제하는 작업만 수행
  • RENAME : 파일 또는 폴더명을 수정하거나 위치(경로)를 변경
  • ETC : 이외에 다른 경우 - 어떠한 사항인지 작성해주세요.

설명

아래 링크에 이슈번호를 적어주세요. 예) .../42cabi/issues/738

#1457

불필요한 deleted_at으로 판단하여 삭제, 로직 변경합니다.
달마다 DELETE 하는 스케줄링 메서드를 제거했습니다.

@Ssuamje Ssuamje added BE Backend tasks HOTFIX labels Nov 30, 2023
@Ssuamje Ssuamje requested review from enaenen and Z1Park November 30, 2023 11:21
@Ssuamje Ssuamje self-assigned this Nov 30, 2023
Z1Park
Z1Park approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@Z1Park Z1Park left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿

enaenen
enaenen approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@enaenen enaenen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리펙토링엔 자네가 필요해 도망가지마 감사합니다 수고하셧씁니다 👍

@Ssuamje Ssuamje merged commit fffafc7 into dev Nov 30, 2023
1 check passed
@Ssuamje Ssuamje deleted the be/dev/fix_extension_delete#1457 branch November 30, 2023 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Z1Park Z1Park Z1Park approved these changes

@enaenen enaenen enaenen approved these changes

Assignees

@Ssuamje Ssuamje

Labels
BE Backend tasks HOTFIX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ssuamje @enaenen @Z1Park