Feature/smar-2708 add additional configuration for deployments in helm #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dart default values
FooRider
reviewed
Jun 26, 2024
Co-authored-by: Peter Pokojný <[email protected]>
FooRider
reviewed
Jun 26, 2024
FooRider
reviewed
Jun 26, 2024
…oyments-in-helm' of github.com:innovatrics/sf-helm into feature/SMAR-2708-add-additional-configuration-for-deployments-in-helm
FooRider
approved these changes
Jun 26, 2024
Temppus
approved these changes
Jun 26, 2024
egid-fertal-inno
deleted the
feature/SMAR-2708-add-additional-configuration-for-deployments-in-helm
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirment was that we should be able to configure via helmchart those two deployment properites:
updateStrategy
revisionHistoryLimit
It was added to values file as:
revisionHistoryLimit:
updateStrategy: {}
when they are empty, default value is used