fix: escape node.__dirname (web-infra-dev#8172)

inottn · Oct 20, 2024 · e616982 · e616982
1 parent 539b10f
commit e616982
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 1 deletion.
diff --git a/crates/rspack_plugin_javascript/src/parser_plugin/node_stuff_plugin.rs b/crates/rspack_plugin_javascript/src/parser_plugin/node_stuff_plugin.rs
@@ -83,7 +83,9 @@ impl JavascriptParserPlugin for NodeStuffPlugin {
           .push(Box::new(ConstDependency::new(
             ident.span.real_lo(),
             ident.span.real_hi(),
-            format!("'{dirname}'").into(),
+            serde_json::to_string(&dirname)
+              .expect("should render dirname")
+              .into(),
             None,
           )));
         return Some(true);

diff --git a/packages/rspack-test-tools/tests/configCases/parsing/rspack-issue-8170/dir1/dir2/file.js b/packages/rspack-test-tools/tests/configCases/parsing/rspack-issue-8170/dir1/dir2/file.js
@@ -0,0 +1 @@
+exports.dirname = __dirname;
diff --git a/packages/rspack-test-tools/tests/configCases/parsing/rspack-issue-8170/index.js b/packages/rspack-test-tools/tests/configCases/parsing/rspack-issue-8170/index.js
@@ -0,0 +1,3 @@
+it("should define __dirname", function() {
+	expect(require("./dir1/dir2/file").dirname).toMatch(/^dir1[\\\/]dir2$/);
+});
diff --git a/packages/rspack-test-tools/tests/configCases/parsing/rspack-issue-8170/rspack.config.js b/packages/rspack-test-tools/tests/configCases/parsing/rspack-issue-8170/rspack.config.js
@@ -0,0 +1,6 @@
+/** @type {import("@rspack/core").Configuration} */
+module.exports = {
+	node: {
+		__dirname: true
+	}
+};