review changes

inovex · Oct 5, 2023 · ca525ff · ca525ff
1 parent 96ec6af
commit ca525ff
Show file tree

Hide file tree

Showing 8 changed files with 87 additions and 45 deletions.
diff --git a/src/components/Footer/Footer.tsx b/src/components/Footer/Footer.tsx
@@ -33,7 +33,7 @@ export const Footer = () => {
               <a
                 href="https://github.com/inovex"
                 target="_blank"
-                aria-label="github"
+                aria-label="GitHub"
               >
                 <Github />
               </a>
@@ -42,7 +42,7 @@ export const Footer = () => {
               <a
                 href="https://www.linkedin.com/company/inovex/"
                 target="_blank"
-                aria-label="linkedin"
+                aria-label="LinkedIn"
               >
                 <Linkedin />
               </a>
@@ -51,7 +51,7 @@ export const Footer = () => {
               <a
                 href="https://www.xing.com/companies/inovexgmbh"
                 target="_blank"
-                aria-label="xing"
+                aria-label="XING"
               >
                 <Xing />
               </a>
@@ -69,7 +69,7 @@ export const Footer = () => {
               <a
                 href="https://www.instagram.com/inovexlife/"
                 target="_blank"
-                aria-label="instagram"
+                aria-label="Instagram"
               >
                 <Instagram />
               </a>
@@ -78,7 +78,7 @@ export const Footer = () => {
               <a
                 href="https://www.facebook.com/inovexde"
                 target="_blank"
-                aria-label="facebook"
+                aria-label="Facebook"
               >
                 <Facebook />
               </a>

diff --git a/src/components/Uniqueness.tsx b/src/components/Uniqueness.tsx
@@ -1,4 +1,3 @@
-import { useEffect, useState } from "react";
 import "./Uniqueness.scss";
 
 export const Uniqueness = () => (

diff --git a/src/layouts/Layout.astro b/src/layouts/Layout.astro
@@ -29,7 +29,7 @@ const { title } = Astro.props;
       <main>
         <slot />
       </main>
-      <Footer client:visible />
+      <Footer />
     </div>
   </body>
 </html>

diff --git a/src/layouts/LegalLayout.astro b/src/layouts/LegalLayout.astro
@@ -18,7 +18,7 @@ const navItems = [
 ];
 ---
 
-<Layout title="scrumlr">
+<Layout title="Scrumlr | Legal Documents">
   <div class="legal">
     <aside>
       <nav>

diff --git a/src/pages/Legal/Cookies.astro b/src/pages/Legal/Cookies.astro
@@ -1,5 +1,6 @@
 ---
 import LegalLayout from "../../layouts/LegalLayout.astro";
+import "./legal.scss";
 ---
 
 <LegalLayout>
@@ -55,17 +56,69 @@ import LegalLayout from "../../layouts/LegalLayout.astro";
   </p>
 
   <ul>
-    <li>Google</li>
-    <li>Chrome</li>
-    <li>Mozilla</li>
-    <li>Firefox</li>
-    <li>Apple</li>
-    <li>Safari</li>
-    <li>Microsoft</li>
-    <li>Internet Explorer</li>
-    <li>Microsoft Edge</li>
-    <li>Brave</li>
-    <li>Opera</li>
+    <li>
+      <a
+        href="https://support.google.com/chrome/answer/95647?hl=en&co=GENIE.Platform%3DDesktop"
+        target="_blank"
+        aria-label="Information on how to manage Cookies in Google Chrome (opens in a new tab)"
+      >
+        Google Chrome
+      </a>
+    </li>
+    <li>
+      <a
+        href="https://support.mozilla.org/en-US/kb/clear-cookies-and-site-data-firefox"
+        target="_blank"
+        aria-label="Information on how to manage Cookies in Mozilla Firefox (opens in a new tab)"
+      >
+        Mozilla Firefox
+      </a>
+    </li>
+    <li>
+      <a
+        href="https://support.apple.com/en-gb/guide/safari/manage-cookies-and-website-data-sfri11471/mac"
+        target="_blank"
+        aria-label="Information on how to manage Cookies in Apple Safari (opens in a new tab)"
+      >
+        Apple Safari
+      </a>
+    </li>
+    <li>
+      <a
+        href="https://support.microsoft.com/en-gb/help/17442/windows-internet-explorer-delete-manage-cookies"
+        target="_blank"
+        aria-label="Information on how to manage Cookies in Microsoft Internet Explorer (opens in a new tab)"
+      >
+        Microsoft Internet Explorer
+      </a>
+    </li>
+    <li>
+      <a
+        href="https://support.microsoft.com/en-us/microsoft-edge/delete-cookies-in-microsoft-edge-63947406-40ac-c3b8-57b9-2a946a29ae09"
+        target="_blank"
+        aria-label="Information on how to manage Cookies in Microsoft Edge (opens in a new tab)"
+      >
+        Microsoft Edge
+      </a>
+    </li>
+    <li>
+      <a
+        href="https://support.brave.com/hc/en-us/articles/360050634931-How-Do-I-Manage-Cookies-In-Brave-"
+        target="_blank"
+        aria-label="Information on how to manage Cookies in Brave (opens in a new tab)"
+      >
+        Brave
+      </a>
+    </li>
+    <li>
+      <a
+        href="https://blogs.opera.com/news/2015/08/how-to-manage-cookies-in-opera/"
+        target="_blank"
+        aria-label="Information on how to manage Cookies in Opera (opens in a new tab)"
+      >
+        Opera
+      </a>
+    </li>
   </ul>
   <p>
     Users may also manage certain categories of Trackers used on mobile apps by
@@ -78,7 +131,3 @@ import LegalLayout from "../../layouts/LegalLayout.astro";
     scrumlr.io.
   </p>
 </LegalLayout>
-
-<script>
-  import "./legal.scss";
-</script>
diff --git a/src/pages/Legal/Privacy.astro b/src/pages/Legal/Privacy.astro
@@ -1,5 +1,6 @@
 ---
 import LegalLayout from "../../layouts/LegalLayout.astro";
+import "./legal.scss";
 ---
 
 <LegalLayout>
@@ -222,7 +223,3 @@ import LegalLayout from "../../layouts/LegalLayout.astro";
     stop using the Services and deactivate your account(s), as outlined above.
   </p>
 </LegalLayout>
-
-<script>
-  import "./legal.scss";
-</script>
diff --git a/src/pages/Legal/Terms.astro b/src/pages/Legal/Terms.astro
@@ -1,5 +1,6 @@
 ---
 import LegalLayout from "../../layouts/LegalLayout.astro";
+import "./legal.scss";
 ---
 
 <LegalLayout>
@@ -572,7 +573,3 @@ import LegalLayout from "../../layouts/LegalLayout.astro";
     jurisdiction.
   </p>
 </LegalLayout>
-
-<script>
-  import "./legal.scss";
-</script>
diff --git a/src/pages/index.astro b/src/pages/index.astro
@@ -1,18 +1,18 @@
 ---
-import {ReachNewHeights} from "../views/ReachNewHeights/ReachNewHeights";
-import Choices from '../components/Choices';
-import { Uniqueness } from '../components/Uniqueness';
-import { Mobile } from '../components/Mobile';
-import Layout from '../layouts/Layout.astro';
-import TargetUser from '../views/TargetUser/TargetUser.astro';
-import {AboutUs} from "../views/AboutUs/AboutUs";
+import { ReachNewHeights } from "../views/ReachNewHeights/ReachNewHeights";
+import Choices from "../components/Choices";
+import { Uniqueness } from "../components/Uniqueness";
+import { Mobile } from "../components/Mobile";
+import Layout from "../layouts/Layout.astro";
+import TargetUser from "../views/TargetUser/TargetUser.astro";
+import { AboutUs } from "../views/AboutUs/AboutUs";
 ---
 
-<Layout title="scrumlr">
-    <ReachNewHeights />
-	<Choices client:visible />
-	<Uniqueness client:idle />
-	<Mobile client:idle />
-	<TargetUser />
-	<AboutUs />
+<Layout title="Scrumlr">
+  <ReachNewHeights />
+  <Choices client:visible />
+  <Uniqueness />
+  <Mobile />
+  <TargetUser />
+  <AboutUs />
 </Layout>
-Original file line number
+Diff line change
@@ Expand Up / @@ -29,7 +29,7 @@ const { title } = Astro.props; @@
           <main>
             <slot />
           </main>
-          <Footer client:visible />
+          <Footer />
         </div>
       </body>
     </html>
@@ Expand Down @@