Refactor AddressNetwork -> NetworkId
#277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eAddress` handling
# Conflicts: # codec/src/map_parameters.rs
lowhung
requested review from
SupernaviX,
golddydev,
sandtreader and
whankinsiv
lowhung
commented
Oct 23, 2025
| ) -> Result<()> { | ||
| let stake_addresses = delegators.iter().map(|(addr, _)| (addr).clone()).collect(); | ||
| let stake_key_to_input: HashMap<KeyHash, _> = delegators | ||
| .iter() |
There was a problem hiding this comment.
Let's just iterate once and build both the stake addresses and stake_key_to_input. This was a fix from the previous PR I worked on.
lowhung
force-pushed
the
lowhung/275-remove-address-network
branch
from
8a19cdd to
a08bbdb
Compare
SupernaviX
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #275
This pull request replaces
AddressNetworkwithNetworkIdand removes unnecessary clones in the delegation extraction method -> updating the delegators for a drep.