Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable legacy prism node #828

Merged
merged 3 commits into from
Jan 15, 2024
Merged

Conversation

womfoo
Copy link
Contributor

@womfoo womfoo commented Dec 8, 2023

Overview

This allows running prism v1.4 on k8s
are commonly forgotten -->

Pre-submit checklist:

  • Self-reviewed the diff
  • New code has proper comments/documentation/tests
  • Any changes not covered by tests have been tested manually
  • The README files are updated
  • If new libraries are included, they have licenses compatible with our project
  • If there is a db migration altering existing tables, there is a proper migration test

Pre-merge checklist:

  • Commits have useful messages
  • Review clarifications made it into the code

Signed-off-by: Kranium Gikos Mendoza <[email protected]>
Signed-off-by: Kranium Gikos Mendoza <[email protected]>
@womfoo womfoo requested a review from a user December 8, 2023 06:20
@atala-dev
Copy link
Contributor

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors
✅ REPOSITORY dustilock yes no
✅ REPOSITORY git_diff yes no
✅ REPOSITORY syft yes no

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

github-actions bot commented Dec 8, 2023

Unit Test Results

328 tests  ±0   327 ✔️ ±0   41s ⏱️ +5s
  48 suites ±0       1 💤 ±0 
  48 files   ±0       0 ±0 

Results for commit 62acb7f. ± Comparison against base commit 30a8164.

@womfoo womfoo merged commit 15e6865 into main Jan 15, 2024
4 checks passed
@womfoo womfoo deleted the ATL-5755-enable-legacy-prism-node branch January 15, 2024 06:10
atala-dev added a commit that referenced this pull request May 17, 2024
# [2.3.0](v2.2.1...v2.3.0) (2024-05-17)

### Bug Fixes

* **node:** edit docker publish path in tragets [#852](#852) ([b9410fe](b9410fe))
* remove v in docker image version tag ([#826](#826)) ([30a8164](30a8164))

### Features

* enable legacy prism node ([#828](#828)) ([15e6865](15e6865))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants