Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add AnonCred method specification #867

Closed
wants to merge 2 commits into from

Conversation

EzequielPostan
Copy link
Contributor

@EzequielPostan EzequielPostan commented Jul 11, 2024

This PR adds a draft for the AnonCred method specification based on the PRISM DID method

Note: this is a draft for review only. The actual spec will be published in a different repository to be defined. I added it here for internal review first.

Nicer read at: https://github.com/input-output-hk/atala-prism/blob/ATL-7317-anon-cred-method-spec/AnonCred-method-spec.md

Overview

Screenshots

Checklists

Pre-submit checklist:

  • Self-reviewed the diff
  • New code has proper comments/documentation/tests
  • Any changes not covered by tests have been tested manually
  • The README files are updated
  • If new libraries are included, they have licenses compatible with our project
  • If there is a db migration altering existing tables, there is a proper migration test

Pre-merge checklist:

  • Commits have useful messages
  • Review clarifications made it into the code

This commit adds a draft for the AnonCred method specification based on
the PRISM DID method
@Dale-iohk
Copy link

Dale-iohk commented Jul 11, 2024

Logo
Checkmarx One – Scan Summary & Detailsa39858fe-8204-4408-b31d-5b906457299a

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /unit-tests.yml: 41
MEDIUM Unpinned Actions Full Length Commit SHA /release.yml: 38
MEDIUM Unpinned Actions Full Length Commit SHA /release.yml: 55
MEDIUM Unpinned Actions Full Length Commit SHA /scala-steward.yml: 30
MEDIUM Unpinned Actions Full Length Commit SHA /unit-tests.yml: 25
MEDIUM Unpinned Actions Full Length Commit SHA /release.yml: 44
MEDIUM Unpinned Actions Full Length Commit SHA /release.yml: 34
MEDIUM Unpinned Actions Full Length Commit SHA /release.yml: 48
MEDIUM Unpinned Actions Full Length Commit SHA /pr-lint.yml: 18
MEDIUM Unpinned Actions Full Length Commit SHA /release.yml: 63
MEDIUM Unpinned Actions Full Length Commit SHA /scala-steward.yml: 22
MEDIUM Unpinned Actions Full Length Commit SHA /lint.yml: 28
MEDIUM Unpinned Actions Full Length Commit SHA /release.yml: 61

@atala-dev
Copy link
Contributor

atala-dev commented Jul 11, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors
⚠️ MARKDOWN markdownlint 1 23
✅ MARKDOWN markdown-link-check 1 0
✅ MARKDOWN markdown-table-formatter 1 0
✅ REPOSITORY dustilock yes no
✅ REPOSITORY git_diff yes no
⚠️ REPOSITORY kics yes 1
✅ REPOSITORY syft yes no

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

Unit Test Results

288 tests  ±0   288 ✔️ ±0   22s ⏱️ ±0s
  36 suites ±0       0 💤 ±0 
  36 files   ±0       0 ±0 

Results for commit 00fe7d5. ± Comparison against base commit 0bb23aa.

This commit adds reference links and improves text fluency
@EzequielPostan
Copy link
Contributor Author

moved to the PRISM DID Method repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants