feat(web-extension): detect bg script when on firefox - LW-11944 #1580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhyslbw
previously approved these changes
Feb 3, 2025
|
there are some unit tests failing. I will fix them shortly |
rhyslbw
previously approved these changes
Feb 3, 2025
Firefox runs background script in a hidden page, so it has a window object.
mirceahasegan
force-pushed
the
feat/detect-background-script-on-firefox
branch
from
74443fd to
029cc2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Make bg script detection more robust
Firefox runs background script in a hidden page,
so it has a window object.
Proposed Solution
Check for
runtime.getBackgroundPagefunction which exists in firefox only on background page.Important Changes Introduced