Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust/cardano-chain-follower): add thread and mmap file stats #150

Merged
merged 25 commits into from
Jan 21, 2025

Conversation

bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Jan 15, 2025

Description

Add thread and memory map file statistics

Related Issue(s)

Closes #145

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@bkioshn bkioshn marked this pull request as draft January 15, 2025 01:14
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 266/266}$ | ${\color{red}Fail: 0/266}$ |

@bkioshn bkioshn self-assigned this Jan 15, 2025
@bkioshn bkioshn added the enhancement New feature or request label Jan 15, 2025
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 266/266}$ | ${\color{red}Fail: 0/266}$ |

@bkioshn bkioshn marked this pull request as ready for review January 15, 2025 04:42
@bkioshn bkioshn added the review me PR is ready for review label Jan 15, 2025
@bkioshn bkioshn requested review from stevenj and removed request for stevenj January 15, 2025 04:43
@bkioshn bkioshn marked this pull request as draft January 15, 2025 04:49
@bkioshn bkioshn removed the review me PR is ready for review label Jan 15, 2025
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 266/266}$ | ${\color{red}Fail: 0/266}$ |

@bkioshn bkioshn marked this pull request as ready for review January 15, 2025 07:57
@bkioshn bkioshn requested review from stevenj and Mr-Leshiy January 15, 2025 07:57
@bkioshn bkioshn added the review me PR is ready for review label Jan 15, 2025
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 266/266}$ | ${\color{red}Fail: 0/266}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 266/266}$ | ${\color{red}Fail: 0/266}$ |

@bkioshn bkioshn requested a review from apskhem January 16, 2025 09:19
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 268/268}$ | ${\color{red}Fail: 0/268}$ |

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 268/268}$ | ${\color{red}Fail: 0/268}$ |

@bkioshn bkioshn marked this pull request as ready for review January 20, 2025 01:28
@bkioshn bkioshn requested a review from stevenj January 20, 2025 01:28
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 269/269}$ | ${\color{red}Fail: 0/269}$ |

rust/catalyst-types/src/mmap_file.rs Outdated Show resolved Hide resolved
rust/catalyst-types/src/mmap_file.rs Outdated Show resolved Hide resolved
rust/catalyst-types/src/mmap_file.rs Outdated Show resolved Hide resolved
rust/catalyst-types/src/mmap_file.rs Outdated Show resolved Hide resolved
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 269/269}$ | ${\color{red}Fail: 0/269}$ |

@bkioshn bkioshn requested a review from stevenj January 20, 2025 15:25
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Put the word async in tasks that are async and run with tokio::spawn

rust/cardano-chain-follower/src/turbo_downloader/mod.rs Outdated Show resolved Hide resolved
rust/cardano-chain-follower/src/turbo_downloader/mod.rs Outdated Show resolved Hide resolved
rust/cardano-chain-follower/src/turbo_downloader/mod.rs Outdated Show resolved Hide resolved
rust/cardano-chain-follower/src/turbo_downloader/mod.rs Outdated Show resolved Hide resolved
rust/cardano-chain-follower/src/stats/thread/mod.rs Outdated Show resolved Hide resolved
@stevenj stevenj self-requested a review January 21, 2025 06:35
Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 269/269}$ | ${\color{red}Fail: 0/269}$ |

Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Test Report | ${\color{lightgreen}Pass: 271/271}$ | ${\color{red}Fail: 0/271}$ |

@bkioshn bkioshn requested a review from apskhem January 21, 2025 11:36
@bkioshn bkioshn merged commit 74e0fb9 into main Jan 21, 2025
20 of 22 checks passed
@bkioshn bkioshn deleted the feat/thread_mmap_stats branch January 21, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request review me PR is ready for review
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add thread statistics details for cardano-chain-follower
3 participants