Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-863] Refactor topbar to use relative position #2782

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

lucas-barros
Copy link
Contributor

@lucas-barros lucas-barros commented Dec 10, 2021

This PR refactors the topbar to use relative positioned elements.

Todos

  • Todo

Screenshots

Screen Shot 2021-12-13 at 11 39 36

Screen Shot 2021-12-13 at 11 40 28

Screen Shot 2021-12-13 at 11 38 40

Screen Shot 2021-12-13 at 11 39 19


Testing Checklist


Review Checklist

Basics

  • PR has been assigned and has appropriate labels (feature/bug/chore, release-x.x.x)
  • PR is updated to the most recent version of the target branch (and there are no conflicts)
  • PR has a good description that summarizes all changes
  • PR has default-sized Daedalus window screenshots or animated GIFs of important UI changes:
    • In English
    • In Japanese
  • CHANGELOG entry has been added to the top of the appropriate section (Features, Fixes, Chores) and is linked to the correct PR on GitHub
  • Automated tests: All acceptance and unit tests are passing (yarn test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn package / CI builds)
  • There are no flow errors or warnings (yarn flow:test)
  • There are no lint errors or warnings (yarn lint)
  • There are no prettier errors or warnings (yarn prettier:check)
  • There are no missing translations (running yarn manage:translations produces no changes)
  • Text changes are proofread and approved (Jane Wild / Amy Reeve)
  • Japanese text changes are proofread and approved (Junko Oda)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly commented and documented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-renderings
  • Any code that only works in main process is neatly separated from components

Testing

  • New feature/change is covered by acceptance tests
  • New feature/change is manually tested and approved by QA team
  • All existing acceptance tests are still up-to-date
  • New feature/change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review

  • Merge the PR
  • Delete the source branch
  • Move the ticket to done column on the YouTrack board
  • Update Slack QA thread by marking it with a green checkmark

@lucas-barros lucas-barros force-pushed the chore/ddw-863-refactor-topbar-to-use-relative-position branch from 14ab274 to cdc77b1 Compare December 13, 2021 13:42
@lucas-barros lucas-barros changed the title [DDW-863] Remove absolute position styles [DDW-863] Refactor topbar to use relative position Dec 13, 2021
@lucas-barros lucas-barros force-pushed the chore/ddw-863-refactor-topbar-to-use-relative-position branch from cdc77b1 to fa9e423 Compare December 13, 2021 13:50
@lucas-barros lucas-barros marked this pull request as ready for review December 14, 2021 12:16
@lucas-barros lucas-barros requested review from a team December 14, 2021 12:19
@gabriela-ponce
Copy link

@lucas-barros Here's a list of issues on this PR:

  • The Daedalus icon is not centered. Check this video, it's ok on the initial settings screen and then, it's off.
  • The name of the wallets is also not centered on any size. Check this screenshot.
  • There is some delay adjusting the alignment of the discreet mode tooltip. Check this video.

@przemyslaw-wlodek przemyslaw-wlodek dismissed their stale review December 16, 2021 17:08

Haven't tested the whole checklist yet


### Chores

- Refactor topbar to use relative position ([PR 2782](https://github.com/input-output-hk/daedalus/pull/2782))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Past tense 'Refactored'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants