-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-863] Refactor topbar to use relative position #2782
Open
lucas-barros
wants to merge
4
commits into
develop
Choose a base branch
from
chore/ddw-863-refactor-topbar-to-use-relative-position
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[DDW-863] Refactor topbar to use relative position #2782
lucas-barros
wants to merge
4
commits into
develop
from
chore/ddw-863-refactor-topbar-to-use-relative-position
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucas-barros
force-pushed
the
chore/ddw-863-refactor-topbar-to-use-relative-position
branch
from
December 13, 2021 13:42
14ab274
to
cdc77b1
Compare
lucas-barros
changed the title
[DDW-863] Remove absolute position styles
[DDW-863] Refactor topbar to use relative position
Dec 13, 2021
lucas-barros
force-pushed
the
chore/ddw-863-refactor-topbar-to-use-relative-position
branch
from
December 13, 2021 13:50
cdc77b1
to
fa9e423
Compare
@lucas-barros Here's a list of issues on this PR:
|
przemyslaw-wlodek
previously approved these changes
Dec 16, 2021
przemyslaw-wlodek
dismissed
their stale review
December 16, 2021 17:08
Haven't tested the whole checklist yet
mchappell
reviewed
Dec 23, 2021
|
||
### Chores | ||
|
||
- Refactor topbar to use relative position ([PR 2782](https://github.com/input-output-hk/daedalus/pull/2782)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Past tense 'Refactored'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the topbar to use relative positioned elements.
Todos
Screenshots
Testing Checklist
Review Checklist
Basics
feature
/bug
/chore
,release-x.x.x
)yarn test
)yarn dev
)yarn package
/ CI builds)yarn flow:test
)yarn lint
)yarn prettier:check
)yarn manage:translations
produces no changes)yarn storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review
done
column on the YouTrack board