[DDW-1190] Set decimal places to 2 when showing the sync percentage #3106
Conversation
… 2 fixed digit places
| logger.error('SyncingProgress::Percentage::Error parsing sync percentage', { | ||
| error, | ||
| }); | ||
| return '-'; |
There was a problem hiding this comment.
@danielmain is this - a requirement or we can return e.g. 0% ?
There was a problem hiding this comment.
I am uncertain if onParsingError we show 0% percentage sync. People will think they have to wait if they see 0% where there is actually an error.
Should we show "Error parsing" ?
There was a problem hiding this comment.
hmmm, yeah. Maybe we can keep it as is and show -. It is better than showing the error that we are not able to parse the data or, like you said, confuse users by showing 0%
There was a problem hiding this comment.
The Sync progress now shows the decimal .00 at starting screen but still not fetching the actual progress and always stays integer.
Please see the record for details.
| @@ -68,7 +68,7 @@ const createHandleNewLogLine = (mainWindow: BrowserWindow) => { | |||
| return; | |||
| } | |||
|
|
|||
| const progress = Math.floor(parseFloat(unparsedProgress)); | |||
| const progress = parseFloat(unparsedProgress); | |||
There was a problem hiding this comment.
This PR follow the suggestion in this issue: #3103 to set a fix decimal place to 2.
Expect: 99.89%, 99.90%, 99.91%
Actual: 99.89%, 99.9%, 99.91%
Screenshots
Basics
input-output-hk/daedalus-devandinput-output-hk/daedalus-qaassigned as PR reviewersrun Chromaticlabel to PR to trigger the run)release-vNext,feature/bug/chore,WIP)yarn manage:translationsproduces no changes)yarn storybook)yarn.lockfile is updatedCode Quality
Testing
After Review