Add mempool notifier sub #2529
Closed
Add mempool notifier sub #2529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecioppettini
added
enhancement
the serialization can change, but use json for now
add also setting to configuration builder, in order to test it, and improve the panic handling of the notifier client
in order to avoid platform specific dependencies in Cargo.lock
the new connection requests are handled through a new message tip changes are handled with tokio::watch because we only care about the latest state, but block changes use a broadcast to keep old ones too
ecioppettini
force-pushed
the
add-blockchain-event-notifier-service
branch
from
5c7253c
to
10afb4e
Compare
ecioppettini
force-pushed
the
add-mempool-notifier-sub
branch
from
68ab462
to
8a91afd
Compare
Comment on lines
+95
to
+98
| mempool_sender.send(MemPoolMessage::FragmentRejected(fragment_id)) | ||
| { | ||
| () | ||
| } |
There was a problem hiding this comment.
I don't really understand the purpose of the if let block here. Can't we use map_err or something else?
ecioppettini
force-pushed
the
add-blockchain-event-notifier-service
branch
from
941a3f0
to
7c6c721
Compare
ecioppettini
force-pushed
the
add-blockchain-event-notifier-service
branch
from
7c6c721
to
5c92bf8
Compare
ecioppettini
force-pushed
the
add-blockchain-event-notifier-service
branch
from
5c92bf8
to
1cc7bf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
base branch is #2378 to show changes more clearly (and it would have to be merged first anyway).
Motivation
To be able to know about fragment rejection or acceptance asynchronously.
Summary
This basically sends a message each time a fragment status is modified in the logs, to anyone with an open connection on the
api/v1/notifier/mempoolendpoint. For now rejection reason is not added, only the id.This also moves the previous endpoint from
api/v1/notifertoapi/v1/notifier/blocks.Other
TODO: update the tests
To think about: graphql has subscriptions which can be used with websockets, so we could have a little schema instead of multiple endpoints. I'm not sure if it's worth it, especially considering that juniper doesn't have them finished.